From ade596121bc834502c63cdedcd8f68a1f490599d Mon Sep 17 00:00:00 2001 From: ameerj <52414509+ameerj@users.noreply.github.com> Date: Fri, 18 Mar 2022 23:44:24 -0400 Subject: core: Reduce unused includes --- src/core/file_sys/directory.h | 1 - src/core/file_sys/patch_manager.cpp | 1 - 2 files changed, 2 deletions(-) (limited to 'src/core/file_sys') diff --git a/src/core/file_sys/directory.h b/src/core/file_sys/directory.h index 21c7aefc8..9a3b62117 100644 --- a/src/core/file_sys/directory.h +++ b/src/core/file_sys/directory.h @@ -5,7 +5,6 @@ #pragma once #include -#include #include "common/common_funcs.h" #include "common/common_types.h" diff --git a/src/core/file_sys/patch_manager.cpp b/src/core/file_sys/patch_manager.cpp index f19ac4607..5882b971b 100644 --- a/src/core/file_sys/patch_manager.cpp +++ b/src/core/file_sys/patch_manager.cpp @@ -10,7 +10,6 @@ #include "common/hex_util.h" #include "common/logging/log.h" #include "common/settings.h" -#include "common/string_util.h" #include "core/core.h" #include "core/file_sys/common_funcs.h" #include "core/file_sys/content_archive.h" -- cgit v1.2.3 From 923decae5a5098cb9d254e008ed61fc5e07ced38 Mon Sep 17 00:00:00 2001 From: ameerj <52414509+ameerj@users.noreply.github.com> Date: Sat, 19 Mar 2022 00:23:48 -0400 Subject: common: Reduce unused includes --- src/common/alignment.h | 1 - src/common/atomic_ops.h | 3 --- src/common/bit_field.h | 1 - src/common/dynamic_library.cpp | 1 - src/common/hex_util.h | 1 - src/common/host_memory.cpp | 1 - src/common/intrusive_red_black_tree.h | 1 - src/common/logging/text_formatter.cpp | 2 -- src/common/logging/text_formatter.h | 1 - src/common/memory_detect.cpp | 2 +- src/common/nvidia_flags.cpp | 1 - src/common/page_table.h | 1 - src/common/parent_of_member.h | 1 - src/common/ring_buffer.h | 1 - src/common/string_util.cpp | 2 -- src/common/telemetry.cpp | 1 - src/common/telemetry.h | 1 - src/common/thread.cpp | 1 - src/common/uint128.h | 1 - src/common/uuid.h | 1 - src/common/virtual_buffer.h | 1 - src/common/wall_clock.cpp | 2 -- src/common/x64/cpu_detect.cpp | 1 - src/common/x64/native_clock.cpp | 2 -- src/common/x64/native_clock.h | 2 -- src/core/file_sys/program_metadata.h | 2 ++ src/core/hle/service/acc/profile_manager.h | 1 + src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.h | 2 ++ src/core/hle/service/nvdrv/devices/nvhost_gpu.h | 1 + src/video_core/cdma_pusher.h | 1 + 30 files changed, 8 insertions(+), 32 deletions(-) (limited to 'src/core/file_sys') diff --git a/src/common/alignment.h b/src/common/alignment.h index 8570c7d3c..e4653bf35 100644 --- a/src/common/alignment.h +++ b/src/common/alignment.h @@ -3,7 +3,6 @@ #pragma once #include -#include #include namespace Common { diff --git a/src/common/atomic_ops.h b/src/common/atomic_ops.h index 2b1f515e8..c488489ea 100644 --- a/src/common/atomic_ops.h +++ b/src/common/atomic_ops.h @@ -4,9 +4,6 @@ #pragma once -#include -#include - #include "common/common_types.h" #if _MSC_VER diff --git a/src/common/bit_field.h b/src/common/bit_field.h index 0f0661172..7f8620e7d 100644 --- a/src/common/bit_field.h +++ b/src/common/bit_field.h @@ -33,7 +33,6 @@ #include #include #include -#include "common/common_funcs.h" #include "common/swap.h" /* diff --git a/src/common/dynamic_library.cpp b/src/common/dynamic_library.cpp index 7f0a10521..11003e1d6 100644 --- a/src/common/dynamic_library.cpp +++ b/src/common/dynamic_library.cpp @@ -2,7 +2,6 @@ // Licensed under GPLv2+ // Refer to the license.txt file included. -#include #include #include diff --git a/src/common/hex_util.h b/src/common/hex_util.h index 5e9b6ef8b..323c8fb33 100644 --- a/src/common/hex_util.h +++ b/src/common/hex_util.h @@ -7,7 +7,6 @@ #include #include #include -#include #include #include #include "common/common_types.h" diff --git a/src/common/host_memory.cpp b/src/common/host_memory.cpp index c465cfc14..229fbe91e 100644 --- a/src/common/host_memory.cpp +++ b/src/common/host_memory.cpp @@ -27,7 +27,6 @@ #include "common/assert.h" #include "common/host_memory.h" #include "common/logging/log.h" -#include "common/scope_exit.h" namespace Common { diff --git a/src/common/intrusive_red_black_tree.h b/src/common/intrusive_red_black_tree.h index b296b639e..eaf5675e3 100644 --- a/src/common/intrusive_red_black_tree.h +++ b/src/common/intrusive_red_black_tree.h @@ -4,7 +4,6 @@ #pragma once -#include "common/alignment.h" #include "common/common_funcs.h" #include "common/parent_of_member.h" #include "common/tree.h" diff --git a/src/common/logging/text_formatter.cpp b/src/common/logging/text_formatter.cpp index 10b2281db..b2cad58d8 100644 --- a/src/common/logging/text_formatter.cpp +++ b/src/common/logging/text_formatter.cpp @@ -10,12 +10,10 @@ #endif #include "common/assert.h" -#include "common/common_funcs.h" #include "common/logging/filter.h" #include "common/logging/log.h" #include "common/logging/log_entry.h" #include "common/logging/text_formatter.h" -#include "common/string_util.h" namespace Common::Log { diff --git a/src/common/logging/text_formatter.h b/src/common/logging/text_formatter.h index 171e74cfe..92c0bf0c5 100644 --- a/src/common/logging/text_formatter.h +++ b/src/common/logging/text_formatter.h @@ -4,7 +4,6 @@ #pragma once -#include #include namespace Common::Log { diff --git a/src/common/memory_detect.cpp b/src/common/memory_detect.cpp index 8cff6ec37..7a75a5ff4 100644 --- a/src/common/memory_detect.cpp +++ b/src/common/memory_detect.cpp @@ -70,4 +70,4 @@ const MemoryInfo& GetMemInfo() { return mem_info; } -} // namespace Common \ No newline at end of file +} // namespace Common diff --git a/src/common/nvidia_flags.cpp b/src/common/nvidia_flags.cpp index d1afd1f1d..c732c233e 100644 --- a/src/common/nvidia_flags.cpp +++ b/src/common/nvidia_flags.cpp @@ -6,7 +6,6 @@ #include -#include "common/fs/file.h" #include "common/fs/fs.h" #include "common/fs/path_util.h" #include "common/nvidia_flags.h" diff --git a/src/common/page_table.h b/src/common/page_table.h index 82d91e9f3..13f4b44c0 100644 --- a/src/common/page_table.h +++ b/src/common/page_table.h @@ -5,7 +5,6 @@ #pragma once #include -#include #include "common/common_types.h" #include "common/virtual_buffer.h" diff --git a/src/common/parent_of_member.h b/src/common/parent_of_member.h index 58c70b0e7..ad075615b 100644 --- a/src/common/parent_of_member.h +++ b/src/common/parent_of_member.h @@ -7,7 +7,6 @@ #include #include "common/assert.h" -#include "common/common_types.h" namespace Common { namespace detail { diff --git a/src/common/ring_buffer.h b/src/common/ring_buffer.h index 4a8d09806..db6aa6b95 100644 --- a/src/common/ring_buffer.h +++ b/src/common/ring_buffer.h @@ -12,7 +12,6 @@ #include #include #include -#include "common/common_types.h" namespace Common { diff --git a/src/common/string_util.cpp b/src/common/string_util.cpp index 662171138..3695dae4d 100644 --- a/src/common/string_util.cpp +++ b/src/common/string_util.cpp @@ -5,11 +5,9 @@ #include #include #include -#include #include #include -#include "common/logging/log.h" #include "common/string_util.h" #ifdef _WIN32 diff --git a/src/common/telemetry.cpp b/src/common/telemetry.cpp index 98c82cd17..67261c55b 100644 --- a/src/common/telemetry.cpp +++ b/src/common/telemetry.cpp @@ -4,7 +4,6 @@ #include #include -#include "common/assert.h" #include "common/scm_rev.h" #include "common/telemetry.h" diff --git a/src/common/telemetry.h b/src/common/telemetry.h index 3524c857e..f9a824a7d 100644 --- a/src/common/telemetry.h +++ b/src/common/telemetry.h @@ -8,7 +8,6 @@ #include #include #include -#include #include "common/common_funcs.h" #include "common/common_types.h" diff --git a/src/common/thread.cpp b/src/common/thread.cpp index 946a1114d..91c8a8e13 100644 --- a/src/common/thread.cpp +++ b/src/common/thread.cpp @@ -4,7 +4,6 @@ #include -#include "common/error.h" #include "common/logging/log.h" #include "common/thread.h" #ifdef __APPLE__ diff --git a/src/common/uint128.h b/src/common/uint128.h index 4780b2f9d..1ed5d6507 100644 --- a/src/common/uint128.h +++ b/src/common/uint128.h @@ -4,7 +4,6 @@ #pragma once -#include #include #ifdef _MSC_VER diff --git a/src/common/uuid.h b/src/common/uuid.h index fe31e64e6..c450d9e20 100644 --- a/src/common/uuid.h +++ b/src/common/uuid.h @@ -7,7 +7,6 @@ #include #include #include -#include #include "common/common_types.h" diff --git a/src/common/virtual_buffer.h b/src/common/virtual_buffer.h index fb1a6f81f..cac4f4895 100644 --- a/src/common/virtual_buffer.h +++ b/src/common/virtual_buffer.h @@ -4,7 +4,6 @@ #pragma once -#include #include namespace Common { diff --git a/src/common/wall_clock.cpp b/src/common/wall_clock.cpp index 9acf7551e..f30d91692 100644 --- a/src/common/wall_clock.cpp +++ b/src/common/wall_clock.cpp @@ -2,8 +2,6 @@ // Licensed under GPLv2 or any later version // Refer to the license.txt file included. -#include - #include "common/uint128.h" #include "common/wall_clock.h" diff --git a/src/common/x64/cpu_detect.cpp b/src/common/x64/cpu_detect.cpp index d81edb140..f5296b32a 100644 --- a/src/common/x64/cpu_detect.cpp +++ b/src/common/x64/cpu_detect.cpp @@ -4,7 +4,6 @@ #include #include #include -#include #include #include "common/bit_util.h" #include "common/common_types.h" diff --git a/src/common/x64/native_clock.cpp b/src/common/x64/native_clock.cpp index 91b842829..347e41efc 100644 --- a/src/common/x64/native_clock.cpp +++ b/src/common/x64/native_clock.cpp @@ -4,8 +4,6 @@ #include #include -#include -#include #include #include "common/atomic_ops.h" diff --git a/src/common/x64/native_clock.h b/src/common/x64/native_clock.h index 7cbd400d2..2c3082ea0 100644 --- a/src/common/x64/native_clock.h +++ b/src/common/x64/native_clock.h @@ -4,8 +4,6 @@ #pragma once -#include - #include "common/wall_clock.h" namespace Common { diff --git a/src/core/file_sys/program_metadata.h b/src/core/file_sys/program_metadata.h index 1eee916be..32435e123 100644 --- a/src/core/file_sys/program_metadata.h +++ b/src/core/file_sys/program_metadata.h @@ -6,7 +6,9 @@ #include #include + #include "common/bit_field.h" +#include "common/common_funcs.h" #include "common/common_types.h" #include "common/swap.h" #include "core/file_sys/vfs_types.h" diff --git a/src/core/hle/service/acc/profile_manager.h b/src/core/hle/service/acc/profile_manager.h index 17347f7ef..5b690b406 100644 --- a/src/core/hle/service/acc/profile_manager.h +++ b/src/core/hle/service/acc/profile_manager.h @@ -7,6 +7,7 @@ #include #include +#include "common/common_funcs.h" #include "common/common_types.h" #include "common/swap.h" #include "common/uuid.h" diff --git a/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.h b/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.h index 898d00a17..f434f6929 100644 --- a/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.h +++ b/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.h @@ -5,6 +5,8 @@ #pragma once #include + +#include "common/common_funcs.h" #include "common/common_types.h" #include "common/swap.h" #include "core/hle/service/nvdrv/devices/nvdevice.h" diff --git a/src/core/hle/service/nvdrv/devices/nvhost_gpu.h b/src/core/hle/service/nvdrv/devices/nvhost_gpu.h index f27a82bff..3e4f3b6a7 100644 --- a/src/core/hle/service/nvdrv/devices/nvhost_gpu.h +++ b/src/core/hle/service/nvdrv/devices/nvhost_gpu.h @@ -7,6 +7,7 @@ #include #include #include "common/bit_field.h" +#include "common/common_funcs.h" #include "common/common_types.h" #include "common/swap.h" #include "core/hle/service/nvdrv/devices/nvdevice.h" diff --git a/src/video_core/cdma_pusher.h b/src/video_core/cdma_pusher.h index 87b49d6ea..cb1d16b71 100644 --- a/src/video_core/cdma_pusher.h +++ b/src/video_core/cdma_pusher.h @@ -8,6 +8,7 @@ #include #include "common/bit_field.h" +#include "common/common_funcs.h" #include "common/common_types.h" namespace Tegra { -- cgit v1.2.3 From 866b7c20a8958069a048ffa600155ec3cbd2e5f2 Mon Sep 17 00:00:00 2001 From: ameerj <52414509+ameerj@users.noreply.github.com> Date: Sat, 19 Mar 2022 01:50:03 -0400 Subject: general: Fix clang/gcc build errors --- src/common/alignment.h | 1 + src/common/atomic_ops.h | 2 ++ src/common/fs/file.cpp | 1 + src/common/fs/fs_util.cpp | 2 ++ src/common/host_memory.cpp | 1 + src/common/thread.cpp | 1 + src/common/uint128.h | 1 + src/core/crypto/key_manager.h | 5 +---- src/core/file_sys/patch_manager.cpp | 4 ++++ src/shader_recompiler/frontend/ir/opcodes.h | 1 + src/video_core/renderer_vulkan/vk_descriptor_pool.cpp | 1 + src/video_core/textures/astc.cpp | 1 + 12 files changed, 17 insertions(+), 4 deletions(-) (limited to 'src/core/file_sys') diff --git a/src/common/alignment.h b/src/common/alignment.h index e4653bf35..8570c7d3c 100644 --- a/src/common/alignment.h +++ b/src/common/alignment.h @@ -3,6 +3,7 @@ #pragma once #include +#include #include namespace Common { diff --git a/src/common/atomic_ops.h b/src/common/atomic_ops.h index c488489ea..b94d73c7a 100644 --- a/src/common/atomic_ops.h +++ b/src/common/atomic_ops.h @@ -8,6 +8,8 @@ #if _MSC_VER #include +#else +#include #endif namespace Common { diff --git a/src/common/fs/file.cpp b/src/common/fs/file.cpp index b89e785c2..5d71275ef 100644 --- a/src/common/fs/file.cpp +++ b/src/common/fs/file.cpp @@ -8,6 +8,7 @@ #ifdef _WIN32 #include +#include #else #include #endif diff --git a/src/common/fs/fs_util.cpp b/src/common/fs/fs_util.cpp index 1f47c2310..0068112e6 100644 --- a/src/common/fs/fs_util.cpp +++ b/src/common/fs/fs_util.cpp @@ -2,6 +2,8 @@ // Licensed under GPLv2 or any later version // Refer to the license.txt file included. +#include + #include "common/fs/fs_util.h" namespace Common::FS { diff --git a/src/common/host_memory.cpp b/src/common/host_memory.cpp index 229fbe91e..e829af1ac 100644 --- a/src/common/host_memory.cpp +++ b/src/common/host_memory.cpp @@ -18,6 +18,7 @@ #include #include #include +#include "common/scope_exit.h" #endif // ^^^ Linux ^^^ diff --git a/src/common/thread.cpp b/src/common/thread.cpp index 91c8a8e13..946a1114d 100644 --- a/src/common/thread.cpp +++ b/src/common/thread.cpp @@ -4,6 +4,7 @@ #include +#include "common/error.h" #include "common/logging/log.h" #include "common/thread.h" #ifdef __APPLE__ diff --git a/src/common/uint128.h b/src/common/uint128.h index 1ed5d6507..ad1b90414 100644 --- a/src/common/uint128.h +++ b/src/common/uint128.h @@ -12,6 +12,7 @@ #pragma intrinsic(_umul128) #pragma intrinsic(_udiv128) #else +#include #include #endif diff --git a/src/core/crypto/key_manager.h b/src/core/crypto/key_manager.h index 34ea5bbd4..ac1eb8962 100644 --- a/src/core/crypto/key_manager.h +++ b/src/core/crypto/key_manager.h @@ -5,6 +5,7 @@ #pragma once #include +#include #include #include #include @@ -15,10 +16,6 @@ #include "common/common_types.h" #include "core/crypto/partition_data_manager.h" -namespace std::filesystem { -class path; -} - namespace Common::FS { class IOFile; } diff --git a/src/core/file_sys/patch_manager.cpp b/src/core/file_sys/patch_manager.cpp index 5882b971b..c4e185757 100644 --- a/src/core/file_sys/patch_manager.cpp +++ b/src/core/file_sys/patch_manager.cpp @@ -10,6 +10,10 @@ #include "common/hex_util.h" #include "common/logging/log.h" #include "common/settings.h" +#ifndef _WIN32 +#include "common/string_util.h" +#endif + #include "core/core.h" #include "core/file_sys/common_funcs.h" #include "core/file_sys/content_archive.h" diff --git a/src/shader_recompiler/frontend/ir/opcodes.h b/src/shader_recompiler/frontend/ir/opcodes.h index 9de65c8b2..85f7aac02 100644 --- a/src/shader_recompiler/frontend/ir/opcodes.h +++ b/src/shader_recompiler/frontend/ir/opcodes.h @@ -4,6 +4,7 @@ #pragma once +#include #include #include diff --git a/src/video_core/renderer_vulkan/vk_descriptor_pool.cpp b/src/video_core/renderer_vulkan/vk_descriptor_pool.cpp index 60e45f1b9..d87da2a34 100644 --- a/src/video_core/renderer_vulkan/vk_descriptor_pool.cpp +++ b/src/video_core/renderer_vulkan/vk_descriptor_pool.cpp @@ -2,6 +2,7 @@ // Licensed under GPLv2 or any later version // Refer to the license.txt file included. +#include #include #include #include diff --git a/src/video_core/textures/astc.cpp b/src/video_core/textures/astc.cpp index 25161df1f..28e4beafd 100644 --- a/src/video_core/textures/astc.cpp +++ b/src/video_core/textures/astc.cpp @@ -16,6 +16,7 @@ // #include +#include #include #include #include -- cgit v1.2.3