From 05ef9dfc10c3a52d1dfab50bb7b2a07891a2c3e9 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Wed, 19 Sep 2018 19:19:05 -0400 Subject: file-sys: Default heavy-weight class destructors in the cpp file Several classes have a lot of non-trivial members within them, or don't but likely should have the destructor defaulted in the cpp file for future-proofing/being more friendly to forward declarations. Leaving the destructor unspecified allows the compiler to inline the destruction code all over the place, which is generally undesirable from a code bloat perspective. --- src/core/file_sys/xts_archive.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/core/file_sys/xts_archive.cpp') diff --git a/src/core/file_sys/xts_archive.cpp b/src/core/file_sys/xts_archive.cpp index 0173f71c1..b53f81947 100644 --- a/src/core/file_sys/xts_archive.cpp +++ b/src/core/file_sys/xts_archive.cpp @@ -72,6 +72,8 @@ NAX::NAX(VirtualFile file_, std::array nca_id) Common::HexArrayToString(nca_id, false))); } +NAX::~NAX() = default; + Loader::ResultStatus NAX::Parse(std::string_view path) { if (file->ReadObject(header.get()) != sizeof(NAXHeader)) return Loader::ResultStatus::ErrorBadNAXHeader; -- cgit v1.2.3