From ea7bda25ba99262267acaa179762c83e3e96a232 Mon Sep 17 00:00:00 2001 From: ReinUsesLisp Date: Wed, 26 Aug 2020 01:16:40 +0000 Subject: cpu_interrupt_handler: Make is_interrupted an atomic Fixes a race condition detected from tsan --- src/core/arm/cpu_interrupt_handler.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/core/arm/cpu_interrupt_handler.cpp') diff --git a/src/core/arm/cpu_interrupt_handler.cpp b/src/core/arm/cpu_interrupt_handler.cpp index df0350881..4c717ebe9 100644 --- a/src/core/arm/cpu_interrupt_handler.cpp +++ b/src/core/arm/cpu_interrupt_handler.cpp @@ -7,7 +7,7 @@ namespace Core { -CPUInterruptHandler::CPUInterruptHandler() : is_interrupted{} { +CPUInterruptHandler::CPUInterruptHandler() { interrupt_event = std::make_unique(); } -- cgit v1.2.3 From 56ac22f7371fdf45016972ce9f487cb3f02551ae Mon Sep 17 00:00:00 2001 From: ReinUsesLisp Date: Wed, 26 Aug 2020 01:19:01 +0000 Subject: cpu_interrupt_handler: Misc style changes --- src/core/arm/cpu_interrupt_handler.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/core/arm/cpu_interrupt_handler.cpp') diff --git a/src/core/arm/cpu_interrupt_handler.cpp b/src/core/arm/cpu_interrupt_handler.cpp index 4c717ebe9..9c8898700 100644 --- a/src/core/arm/cpu_interrupt_handler.cpp +++ b/src/core/arm/cpu_interrupt_handler.cpp @@ -7,9 +7,7 @@ namespace Core { -CPUInterruptHandler::CPUInterruptHandler() { - interrupt_event = std::make_unique(); -} +CPUInterruptHandler::CPUInterruptHandler() : interrupt_event{std::make_unique()} {} CPUInterruptHandler::~CPUInterruptHandler() = default; @@ -17,7 +15,7 @@ void CPUInterruptHandler::SetInterrupt(bool is_interrupted_) { if (is_interrupted_) { interrupt_event->Set(); } - this->is_interrupted = is_interrupted_; + is_interrupted = is_interrupted_; } void CPUInterruptHandler::AwaitInterrupt() { -- cgit v1.2.3