From 27650499bc74ec642c253a84fcf7f1c7812fdcac Mon Sep 17 00:00:00 2001 From: David Marcec Date: Sun, 22 Apr 2018 19:02:18 -0700 Subject: GetIUserInterface->CreateUserInterface, Added todos and stub logs. Playreport->PlayReport. --- src/common/logging/log.h | 1 + 1 file changed, 1 insertion(+) (limited to 'src/common') diff --git a/src/common/logging/log.h b/src/common/logging/log.h index 45821850c..ade44d9c7 100644 --- a/src/common/logging/log.h +++ b/src/common/logging/log.h @@ -65,6 +65,7 @@ enum class Class : ClassType { Service_NS, ///< The NS services Service_NVDRV, ///< The NVDRV (Nvidia driver) service Service_PCTL, ///< The PCTL (Parental control) service + Service_PREPO, ///< The PREPO(Play report) service Service_SET, ///< The SET (Settings) service Service_SM, ///< The SM (Service manager) service Service_SPL, ///< The SPL service -- cgit v1.2.3 From f1f7f2cba93631c67dfd8767f69a2a23a6edcf23 Mon Sep 17 00:00:00 2001 From: David Marcec Date: Thu, 26 Apr 2018 14:19:34 -0700 Subject: Added PREPO to logging backend, Removed comments from SaveReportWithUser --- src/common/logging/backend.cpp | 1 + src/core/hle/service/prepo/prepo.cpp | 13 +------------ src/core/hle/service/ssl/ssl.cpp | 2 +- 3 files changed, 3 insertions(+), 13 deletions(-) (limited to 'src/common') diff --git a/src/common/logging/backend.cpp b/src/common/logging/backend.cpp index 26cd75a3e..618be0864 100644 --- a/src/common/logging/backend.cpp +++ b/src/common/logging/backend.cpp @@ -48,6 +48,7 @@ namespace Log { SUB(Service, NS) \ SUB(Service, NVDRV) \ SUB(Service, PCTL) \ + SUB(Service, PREPO) \ SUB(Service, SET) \ SUB(Service, SM) \ SUB(Service, SPL) \ diff --git a/src/core/hle/service/prepo/prepo.cpp b/src/core/hle/service/prepo/prepo.cpp index 02db54827..3c43b8d8c 100644 --- a/src/core/hle/service/prepo/prepo.cpp +++ b/src/core/hle/service/prepo/prepo.cpp @@ -26,18 +26,7 @@ PlayReport::PlayReport(const char* name) : ServiceFramework(name) { }; void PlayReport::SaveReportWithUser(Kernel::HLERequestContext& ctx) { - /*IPC::RequestParser rp{ctx}; - auto Uid = rp.PopRaw>(); - u64 unk = rp.Pop(); - std::vector buffer; - buffer.reserve(ctx.BufferDescriptorX()[0].Size()); - Memory::ReadBlock(ctx.BufferDescriptorX()[0].Address(), buffer.data(), buffer.size()); - - std::vector buffer2; - buffer.reserve(ctx.BufferDescriptorA()[0].Size()); - Memory::ReadBlock(ctx.BufferDescriptorA()[0].Address(), buffer.data(), buffer.size());*/ - // TODO(ogniK): Do we want to add play report? ^ Buffers/Data required for it - + // TODO(ogniK): Do we want to add play report? LOG_WARNING(Service_PREPO, "(STUBBED) called"); IPC::ResponseBuilder rb{ctx, 2}; diff --git a/src/core/hle/service/ssl/ssl.cpp b/src/core/hle/service/ssl/ssl.cpp index 27d91640e..40aea6090 100644 --- a/src/core/hle/service/ssl/ssl.cpp +++ b/src/core/hle/service/ssl/ssl.cpp @@ -106,7 +106,7 @@ void SSL::SetInterfaceVersion(Kernel::HLERequestContext& ctx) { LOG_WARNING(Service_SSL, "(STUBBED) called"); IPC::RequestParser rp{ctx}; u32 unk1 = rp.Pop(); // Probably minor/major? - u32 unk2 = rp.Pop(); + u32 unk2 = rp.Pop(); // TODO(ogniK): Figure out what this does IPC::ResponseBuilder rb{ctx, 2}; rb.Push(RESULT_SUCCESS); -- cgit v1.2.3 From abc23416e8f2a0963a5ddff021788cae7f00dd62 Mon Sep 17 00:00:00 2001 From: David Marcec Date: Thu, 26 Apr 2018 20:03:12 -0700 Subject: Switched to NGLOG_WARNING --- src/common/logging/log.h | 2 +- src/core/hle/service/nfp/nfp.cpp | 4 ++-- src/core/hle/service/prepo/prepo.cpp | 2 +- src/core/hle/service/ssl/ssl.cpp | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) (limited to 'src/common') diff --git a/src/common/logging/log.h b/src/common/logging/log.h index ade44d9c7..1b29ce6e0 100644 --- a/src/common/logging/log.h +++ b/src/common/logging/log.h @@ -65,7 +65,7 @@ enum class Class : ClassType { Service_NS, ///< The NS services Service_NVDRV, ///< The NVDRV (Nvidia driver) service Service_PCTL, ///< The PCTL (Parental control) service - Service_PREPO, ///< The PREPO(Play report) service + Service_PREPO, ///< The PREPO (Play report) service Service_SET, ///< The SET (Settings) service Service_SM, ///< The SM (Service manager) service Service_SPL, ///< The SPL service diff --git a/src/core/hle/service/nfp/nfp.cpp b/src/core/hle/service/nfp/nfp.cpp index a1cd6b24a..cc0247881 100644 --- a/src/core/hle/service/nfp/nfp.cpp +++ b/src/core/hle/service/nfp/nfp.cpp @@ -47,14 +47,14 @@ public: private: void Initialize(Kernel::HLERequestContext& ctx) { - LOG_WARNING(Service_NFP, "(STUBBED) called"); + NGLOG_WARNING(Service_NFP, "(STUBBED) called"); IPC::ResponseBuilder rb{ctx, 2}; rb.Push(RESULT_SUCCESS); } }; void Module::Interface::CreateUserInterface(Kernel::HLERequestContext& ctx) { - LOG_WARNING(Service_NFP, "(STUBBED) called"); + NGLOG_DEBUG(Service_NFP, "called"); IPC::ResponseBuilder rb{ctx, 2, 0, 1}; rb.Push(RESULT_SUCCESS); rb.PushIpcInterface(); diff --git a/src/core/hle/service/prepo/prepo.cpp b/src/core/hle/service/prepo/prepo.cpp index 3c43b8d8c..eaf30ee6b 100644 --- a/src/core/hle/service/prepo/prepo.cpp +++ b/src/core/hle/service/prepo/prepo.cpp @@ -27,7 +27,7 @@ PlayReport::PlayReport(const char* name) : ServiceFramework(name) { void PlayReport::SaveReportWithUser(Kernel::HLERequestContext& ctx) { // TODO(ogniK): Do we want to add play report? - LOG_WARNING(Service_PREPO, "(STUBBED) called"); + NGLOG_WARNING(Service_PREPO, "(STUBBED) called"); IPC::ResponseBuilder rb{ctx, 2}; rb.Push(RESULT_SUCCESS); diff --git a/src/core/hle/service/ssl/ssl.cpp b/src/core/hle/service/ssl/ssl.cpp index 8a85df91a..b3dad8b06 100644 --- a/src/core/hle/service/ssl/ssl.cpp +++ b/src/core/hle/service/ssl/ssl.cpp @@ -103,7 +103,7 @@ SSL::SSL() : ServiceFramework("ssl") { } void SSL::SetInterfaceVersion(Kernel::HLERequestContext& ctx) { - LOG_WARNING(Service_SSL, "(STUBBED) called"); + NGLOG_WARNING(Service_SSL, "(STUBBED) called"); IPC::RequestParser rp{ctx}; u32 unk1 = rp.Pop(); // Probably minor/major? u32 unk2 = rp.Pop(); // TODO(ogniK): Figure out what this does -- cgit v1.2.3