| Age | Commit message (Collapse) | Author |
|---|
|
gl_shader_gen: std::move objects where applicable
|
|
yuzu/bootmanager: Explicitly enable deprecated OpenGL features on compat
|
|
constexpr internally links by default, so the inline specifier is
unnecessary.
|
|
Many of these constructors don't even need to be templated. The only
ones that need to be templated are the ones that actually make use of
the parameter pack.
Even then, since std::vector accepts an initializer list, we can supply
the parameter pack directly to it instead of creating our own copy of
the list, then copying it again into the std::vector.
|
|
Operation() overloads where applicable
These overloads don't actually make use of the parameter pack, so they
can be turned into regular non-template function overloads.
|
|
These don't actually modify instance state, so they can be marked as
const member functions
|
|
This has been left unused since the removal of the vestigial surface
viewer. Given it has no uses left, this can be removed as well.
|
|
file
Given the class contains quite a lot of non-trivial types, place the
constructor and destructor within the cpp file to avoid inlining
construction and destruction code everywhere the class is used.
|
|
Avoids performing copies into the pair being returned. Instead, we can
just move the resources into the pair, avoiding the need to make copies
of both the std::string and ShaderEntries struct.
|
|
ShaderDiskCacheOpenGL
Given the offset is assigned a fixed value in the constructor, we can
just assign it directly and get rid of the need to write the name of the
variable again in the constructor initializer list.
|
|
Given the disk shader cache contains non-trivial types, we should
default it in the cpp file in order to prevent inlining of the
complex destruction logic.
|
|
The standard library expects hash specializations that don't throw
exceptions. Make this explicit in the type to allow selection of better
code paths if possible in implementations.
|
|
LoadDecompiledEntry()
We don't need to load the code into a vector and then construct a string
over the data. We can just create a string with the necessary size ahead
of time, and read the data directly into it, getting rid of an
unnecessary heap allocation.
|
|
std::move does nothing when applied to a const variable. Resources can't
be moved if the object is immutable. With this change, we don't end up
making several unnecessary heap allocations and copies.
|
|
Booleans don't have a guaranteed size, but we still want to have them
integrate into the disk cache system without needing to actually use a
different type. We can do this by supplying non-template overloads for
the bool type.
Non-template overloads always have precedence during function
resolution, so this is safe to provide.
This gets rid of the need to smatter ternary conditionals, as well as
the need to use u8 types to store the value in.
|
|
This is a user-facing string, so it should be marked as translatable.
|
|
explicitly
Allows the graphics breakpoints to compile with implicit string
conversions disabled.
|
|
This allows the microprofile widget to compile with implicit string
conversions disabled.
|
|
Allows compiling the wait tree widget with implicit string conversions
disabled.
|
|
Currently, this overload isn't used, so this wasn't actually hit in any
code, only the float overload is used.
|
|
Co-Authored-By: Mat M. <mathew1800@gmail.com>
|
|
linked
These are only used from within this translation unit, so they don't
need to have external linkage. They were intended to be marked with this
anyways to be consistent with the other service functions.
|
|
Read()/Write().
Previously this would fall through and return successfully, despite
being an out of bounds read or write.
|
|
Renames the members to more accurately indicate what they signify.
"OneShot" and "Sticky" are kind of ambiguous identifiers for the reset
types, and can be kind of misleading. Automatic and Manual communicate
the kind of reset type in a clearer manner. Either the event is
automatically reset, or it isn't and must be manually cleared.
The "OneShot" and "Sticky" terminology is just a hold-over from Citra
where the kernel had a third type of event reset type known as "Pulse".
Given the Switch kernel only has two forms of event reset types, we
don't need to keep the old terminology around anymore.
|
|
SleepClientThread
This reduces the boilerplate that services have to write out the current thread explicitly. Using current thread instead of client thread is also semantically incorrect, and will be a problem when we implement multicore (at which time there will be multiple current threads)
|
|
|
|
|
|
|
|
yuzu/{about_dialog, main}: Specify string conversions explicitly for SCM-related info
|
|
yuzu_cmd: Make OpenGL's context current
|
|
yuzu_cmd: Use OpenGL compat when asked in the settings
|
|
Compatibility profile and the disk shader cache settings shouldn't
be changed at runtime. This aims to address that shadowing those
options.
|
|
|
|
The SDL2 frontend never bound the OpenGL context, resulting on a white
screen and no-ops all over the backend.
|
|
Nvidia's proprietary driver creates a real OpenGL compatibility profile
without this option, meanwhile Intel (and probably AMD, I haven't tested
it) require that QSurfaceFormat::FormatOption::DeprecatedFunctions is
explicitly enabled.
|
|
This was reduced due to happening on most games and at such constant
rate that it affected performance heavily for the end user. In general,
we are well aware of the assert and an implementation is already
planned.
|
|
Silences a -Wreorder warning.
|
|
Avoids inlining destruction logic where applicable, and also makes
forward declarations not cause unexpected compilation errors depending
on where the State class is used.
|
|
function declarations
These only apply in the definition of the function. They can be omitted
from the declaration.
|
|
|
|
We can use the named constant instead of using 32 directly.
|
|
within InitializeRegisterDefaults()
Lessens the amount of code that needs to be read, and gets rid of the
need to introduce an indexing variable. Instead, we just operate on the
objects directly.
|
|
std::memset is used to clear the entire register structure, which
requires that the Regs struct be trivially copyable (otherwise undefined
behavior is invoked). This prevents the case where a non-trivial type is
potentially added to the struct.
|
|
With C++17's deduction guides, the type doesn't need to be explicitly
specified within locking primitives anymore.
|
|
CommandDataContainer
std::move within a copy constructor (on a data member that isn't
mutable) will always result in a copy. Because of that, the behavior of
this copy constructor is identical to the one that would be generated
automatically by the compiler, so we can remove it.
|
|
video_core/memory_manager: Minor tidying
|
|
video_core: Remove a few unused variables and functions
|
|
CMakeLists: Specify /volatile:iso for MSVC
|
|
CMakeLists: Explicitly specify -Wall for the non-MSVC case
|
|
Rasterizer Cache: refactor flushing & optimize memory usage of surfaces
|
