| Age | Commit message (Collapse) | Author |
|---|
|
This doesn't modify any internal state, so it can be made a const member
function to allow its use in const contexts.
|
|
|
|
- Use QStringLiteral where applicable.
- Use const where applicable
- Remove unnecessary precondition check (we already assert the pixbuf
being non null)
|
|
We can utilize qOverload with the signal connections to make the
function deducing a little less ugly.
|
|
|
|
Fills in the missing surface types that were marked as unknown. The
order corresponds with the TextureFormat enum within
video_core/texture.h.
We also don't need to all of these strings as translatable (only the
first string, as it's an English word).
|
|
Since c5d41fd812d7eb1a04f36b76c08fe971cee0868c callback parameters were
changed to use an s64 to represent late cycles instead of an int, so
this was causing a truncation warning to occur here. Changing it to s64
is sufficient to silence the warning.
|
|
These aren't used externally by anything, so they can be made private
data members.
|
|
Replaces header inclusions with forward declarations where applicable
and also removes unused headers within the cpp file. This reduces a few
more dependencies on core/memory.h
|
|
This is a hold over from the 3DS error codes in Citra.
|
|
BitField has been trivially copyable since
e99a14862841841d74be8d0ea9426c2d23546b5e, so we can eliminate these
TODO comments and use ReadObject() directly instead of memcpying the
data.
|
|
|
|
return types
Makes the return type consistently uniform (like the intrinsics we're
wrapping). This also conveniently silences a truncation warning within
the kernel multi_level_queue.
|
|
enum class elements from the same enum can already be compared against
one another without the need for explicitly defined comparison
operators.
|
|
The given string instance doesn't need to be copied entirely, we can
just use a view instead.
|
|
Passing around a 64 byte data struct by value is kind of wasteful,
instead pass a reference to the struct.
|
|
The unknown member here is actually padding due to being passed as a
struct. We can do the same, and remove the need to pop a padding word.
|
|
I realized that I updated the documentation on SwitchBrew a while ago,
but never actually updated the structs within yuzu.
|
|
filesystem: Use a std::string_view in OpenFile()
|
|
gpu_thread: Improve synchronization by using CoreTiming.
|
|
file_sys/control_metadata: Amend naming of members
|
|
hle/service: Resolve unused variable warnings
|
|
gl_shader_decompiler: Fix TXQ types
|
|
yuzu/main: Minor adjustments to OnTransferableShaderCacheOpenFile()
|
|
video_core/renderer_opengl: Remove unnecessary includes
|
|
Rather than make a full copy of the path, we can just use a string view
and truncate the viewed portion of the string instead of creating a totally
new truncated string.
|
|
Temporal generally indicates a relation to time, but this is just
creating a temporary, so this isn't really an accurate name for what the
function is actually doing.
|
|
TXQ returns integer types. Shaders usually do:
R0 = TXQ(); // => int
R0 = static_cast<float>(R0);
If we don't treat it as an integer, it will cast a binary float value as
float - resulting in a corrupted number.
|
|
In several places, we have request parsers where there's nothing to
really parse, simply because the HLE function in question operates on
buffers. In these cases we can just remove these instances altogether.
In the other cases, we can retrieve the relevant members from the parser
and at least log them out, giving them some use.
|
|
Applies the override specifier where applicable. In the case of
destructors that are defaulted in their definition, they can
simply be removed.
This also removes the unnecessary inclusions being done in audin_u and
audrec_u, given their close proximity.
|
|
Quite a few unused includes have built up over time, particularly on
core/memory.h. Removing these includes means the source files including
those files will no longer need to be rebuilt if they're changed, making
compilation slightly faster in this scenario.
|
|
While we're at it, don't use <QtGui> and <QtWidgets> and instead include
exactly which headers we actually need.
|
|
OnTransferableShaderCacheOpenFile()
Allows these strings to have no allocation cost when used at runtime.
|
|
OnTransferableShaderCacheOpenFile()
Rather than scream that the file doesn't exist, we can clearly state
what specifically doesn't exist, to avoid ambiguity, and make it easier
to understand for non-primary English speakers/readers.
|
|
OnTransferableShaderCacheOpenFile()
We can just make the trailing portion of the string part of the
formatting, getting rid of the need to make another temporary string.
|
|
Simplifies the amount of string conversions necessary. We also don't
need to log out what occurs here.
|
|
There's no need to construct a QFile instance just to check for its
existence.
|
|
Introduced within 798d76f4c7018174e58702fb06a042dc8c84f0be, this only
really has an effect within header files.
Silences a -Wpragma-once-outside-header warning with clang.
|
|
service/am: Correct behavior of CreateTransferMemoryStorage()
|
|
frontend: Open transferable shader cache for a selected game in the gamelist
|
|
Better LZ4 compression utilization for the disk based shader cache and the yuzu build system
|
|
gl_shader_manager: Remove reliance on a global accessor within MaxwellUniformData::SetFromRegs()
|
|
kernel/object: Remove unused handle type entry
|
|
Quite a bit of these were out of sync with Switchbrew (and in some cases
entirely wrong). While we're at it, also expand the section of named
members. A segment within the control metadata is used to specify
maximum values for the user, device, and cache storage max sizes and
journal sizes.
These appear to be generally used by the am service (e.g. in
CreateCacheStorage, etc).
|
|
We need to be checking whether or not the given address is within the
kernel address space or if the given address isn't word-aligned and bail
in these scenarios instead of trashing any kernel state.
|
|
|
|
For whatever reason, shared memory was being used here instead of
transfer memory, which (quite clearly) will not work based off the name
of the function.
This corrects this wonky usage of shared memory.
|
|
Also amend erroneous use of size_t. We should be using u64 here.
|
|
|
|
service/am: Implement EnterFatalSection/LeaveFatalSection
|
