| Age | Commit message (Collapse) | Author |
|---|
|
If an error occurs when constructing the PartitionFilesystem instance,
the constructor would be exited early, which wouldn't initialize the
extracted data member, making it possible for other code to perform an
uninitialized read by calling the public IsExtractedType() member
function. This prevents that.
|
|
Like the other two bits of factored out code, this can also be put
within its own function. We can also modify the code so that it accepts
a const reference to a std::vector of files, this way, we can
deduplicate the file retrieval.
Now the constructor for NSP isn't a combination of multiple behaviors in
one spot. It's nice and separate.
|
|
This too, is completely separate behavior from what is in the
constructor, so we can move this to its own isolated function to keep
everything self-contained.
|
|
This behavior is entirely independent of the surrounding code, so it can
be put in its own function to keep the behavior separate.
|
|
nesting
We can use early continues here to reduce the amount of nesting.
|
|
If any of the error paths before the NCA retrieval are taken, it'll
result in program_nca_status being left in an inconsistent state. So we
initialize it by default with a value indicating an error.
|
|
In some games (Splatoon 2 and Splatoon 2 Splatfest World Premiere, notably), pass offset=0 and count=2047 into the ListAddOnContent method which should return all DLCs for the current title. The (presumably) intended behavior is to successfully return a empty array but because of a < v. <= in an if statement, a failure error code was returned causing these games to svcBreak. This fixes that if statement.
|
|
Adds new functions that have been given names to the table. Information
is based off what is provided on Switchbrew.
|
|
Amends the lbl service table to include new names of functions that were
added to Switchbrew.
|
|
These strings are user-facing, so they should be specified as
translatable with tr().
|
|
Keeps the individual behaviors in their own functions, and cleanly
separate. We can also do a little better by converting the relevant IDs
within the core to a QString only once, instead of converting every
string into a std::string.
|
|
This ensures that the proper codec will always be used no matter what.
It also avoids relying on ASCII conversions.
|
|
Disambiguates what the string represents to help translators more easily
understand what it is that they're translating. While we're at it, we
can move the code to its own function, so that we don't need to specify
the same string twice.
|
|
These aren't used outside of this translation unit, so they can be
internally linked.
|
|
Avoid resource-heavy classes and remove quasi-duplicated code.
|
|
|
|
First of all they are foundamentally broken. As our convention is that std::string is always UTF-8, these functions assume that the multi-byte character version of TString (std::string) from windows is also in UTF-8, which is almost always wrong. We are not going to build multi-byte character build, and even if we do, this dirty work should be handled by frontend framework early.
|
|
We always use unicode internally. Any dirty work of conversion with other codec should be handled by frontend framework (Qt). Further more, ShiftJIS/CP1252 are not special (they are not code set used by 3ds, or any guest/host dependencies we have), so there is no reason to specifically include them
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
While PatchExeFS operated on the entire directory, this function operates on the uncompressed NSO. Avoids copying decompression code to PatchManager.
|
|
|
|
|
|
|
|
aoc_u: Implement functions and add support for DLC loading
|
|
|
|
TLDS: Add 1D sampler
|
|
gl_rasterizer_cache: Implement cubemap textures.
|
|
qt: Install System TitleTypes to System NAND
|
|
|
|
Command #5
|
|
Commands #2, #3, and #7
|
|
Previous behavior was to assert. Seems to mirror expected game behavior.
|
|
|
|
Implement ISystemDisplayService::GetDisplayMode
|
|
- Fixes issues with Splatoon 2.
|
|
|
|
|
|
|
|
|
|
|
|
ColorTexture surfaces.
|
|
|
