| Age | Commit message (Collapse) | Author |
|---|
|
LoadDecompiledEntry()
We don't need to load the code into a vector and then construct a string
over the data. We can just create a string with the necessary size ahead
of time, and read the data directly into it, getting rid of an
unnecessary heap allocation.
|
|
std::move does nothing when applied to a const variable. Resources can't
be moved if the object is immutable. With this change, we don't end up
making several unnecessary heap allocations and copies.
|
|
Booleans don't have a guaranteed size, but we still want to have them
integrate into the disk cache system without needing to actually use a
different type. We can do this by supplying non-template overloads for
the bool type.
Non-template overloads always have precedence during function
resolution, so this is safe to provide.
This gets rid of the need to smatter ternary conditionals, as well as
the need to use u8 types to store the value in.
|
|
This is a user-facing string, so it should be marked as translatable.
|
|
explicitly
Allows the graphics breakpoints to compile with implicit string
conversions disabled.
|
|
This allows the microprofile widget to compile with implicit string
conversions disabled.
|
|
Allows compiling the wait tree widget with implicit string conversions
disabled.
|
|
Currently, this overload isn't used, so this wasn't actually hit in any
code, only the float overload is used.
|
|
Co-Authored-By: Mat M. <mathew1800@gmail.com>
|
|
linked
These are only used from within this translation unit, so they don't
need to have external linkage. They were intended to be marked with this
anyways to be consistent with the other service functions.
|
|
Read()/Write().
Previously this would fall through and return successfully, despite
being an out of bounds read or write.
|
|
Renames the members to more accurately indicate what they signify.
"OneShot" and "Sticky" are kind of ambiguous identifiers for the reset
types, and can be kind of misleading. Automatic and Manual communicate
the kind of reset type in a clearer manner. Either the event is
automatically reset, or it isn't and must be manually cleared.
The "OneShot" and "Sticky" terminology is just a hold-over from Citra
where the kernel had a third type of event reset type known as "Pulse".
Given the Switch kernel only has two forms of event reset types, we
don't need to keep the old terminology around anymore.
|
|
SleepClientThread
This reduces the boilerplate that services have to write out the current thread explicitly. Using current thread instead of client thread is also semantically incorrect, and will be a problem when we implement multicore (at which time there will be multiple current threads)
|
|
|
|
|
|
|
|
yuzu/{about_dialog, main}: Specify string conversions explicitly for SCM-related info
|
|
yuzu_cmd: Make OpenGL's context current
|
|
yuzu_cmd: Use OpenGL compat when asked in the settings
|
|
Compatibility profile and the disk shader cache settings shouldn't
be changed at runtime. This aims to address that shadowing those
options.
|
|
|
|
The SDL2 frontend never bound the OpenGL context, resulting on a white
screen and no-ops all over the backend.
|
|
Nvidia's proprietary driver creates a real OpenGL compatibility profile
without this option, meanwhile Intel (and probably AMD, I haven't tested
it) require that QSurfaceFormat::FormatOption::DeprecatedFunctions is
explicitly enabled.
|
|
This was reduced due to happening on most games and at such constant
rate that it affected performance heavily for the end user. In general,
we are well aware of the assert and an implementation is already
planned.
|
|
Silences a -Wreorder warning.
|
|
Avoids inlining destruction logic where applicable, and also makes
forward declarations not cause unexpected compilation errors depending
on where the State class is used.
|
|
function declarations
These only apply in the definition of the function. They can be omitted
from the declaration.
|
|
|
|
We can use the named constant instead of using 32 directly.
|
|
within InitializeRegisterDefaults()
Lessens the amount of code that needs to be read, and gets rid of the
need to introduce an indexing variable. Instead, we just operate on the
objects directly.
|
|
std::memset is used to clear the entire register structure, which
requires that the Regs struct be trivially copyable (otherwise undefined
behavior is invoked). This prevents the case where a non-trivial type is
potentially added to the struct.
|
|
With C++17's deduction guides, the type doesn't need to be explicitly
specified within locking primitives anymore.
|
|
CommandDataContainer
std::move within a copy constructor (on a data member that isn't
mutable) will always result in a copy. Because of that, the behavior of
this copy constructor is identical to the one that would be generated
automatically by the compiler, so we can remove it.
|
|
video_core/memory_manager: Minor tidying
|
|
video_core: Remove a few unused variables and functions
|
|
CMakeLists: Specify /volatile:iso for MSVC
|
|
CMakeLists: Explicitly specify -Wall for the non-MSVC case
|
|
Rasterizer Cache: refactor flushing & optimize memory usage of surfaces
|
|
slot.
It seems instructions marked with the 'exit' flag will not cause an exit when executed within a delay slot.
This was hwtested by fincs.
|
|
This corrects cases where it was possible to write more entries into the
write buffer than were requested. Now, we check the size of the buffer
before actually writing into them.
We were also returning the wrong value for
GetAvailableLanguageCodeCount2(). This was previously returning 64, but
only 17 should have been returned. 64 entries is the size of the static
array used in MakeLanguageCode() within the service binary itself, but
isn't the actual total number of language codes present.
|
|
Corrects the typo in its name and marks the function as a const member
function, given it doesn't actually modify memory manager state.
|
|
Prevents implicit converting constructions of the memory manager.
|
|
Makes the class less surprising when it comes to forward declaring the
type, and also prevents inlining the destruction code of the class,
given it contains non-trivial types.
|
|
Corrects references to non-existent parameters and corrects typos.
|
|
These are able to be omitted from the declaration of functions, since
they don't do anything at the type system level. The definitions of the
functions can retain the use of const though, since they make the
variables immutable in the implementation of the function where they're
used.
|
|
Silences a -Wreorder warning.
|
|
|
|
DeclareInternalFlags()
|
|
function
This isn't used at all, so it can be removed.
|
|
UploadGLMipmapTexture()
This variable is unused entirely, so it can be removed.
|
