| Age | Commit message (Collapse) | Author |
|---|
|
input_common: Treat warnings as errors
|
|
main thread
EmuWindow::PollEvents was called from the GPU thread (or the CPU thread
in sync-GPU mode) when swapping buffers. It had three implementations:
- In GRenderWindow, it didn't actually poll events, just set a flag and
emit a signal to indicate that a frame was displayed.
- In EmuWindow_SDL2_Hide, it did nothing.
- In EmuWindow_SDL2, it did call SDL_PollEvents, but this is wrong
because SDL_PollEvents is supposed to be called on the thread that set
up video - in this case, the main thread, which was sleeping in a
busyloop (regardless of whether sync-GPU was enabled). On macOS this
causes a crash.
To fix this:
- Rename EmuWindow::PollEvents to OnFrameDisplayed, and give it a
default implementation that does nothing.
- In EmuWindow_SDL2, do not override OnFrameDisplayed, but instead have
the main thread call SDL_WaitEvent in a loop.
|
|
logging/settings: Increase maximum log size to 100 MB and add extended logging option
|
|
The parameter is used in this function, so this suppression isn't
necessary.
|
|
Migrates over warnings as errors for input common to match how the
common library treats warnings as errors.
|
|
patch_manager: Remove usages of the global system instance
|
|
core: Make nvservices more standardized
|
|
|
|
functions.
- Used by Animal Cross: New Horizons v1.6.0 update, minimal stub gets this update working.
|
|
With this, only 19 usages of the global system instance remain within
the core library.
We're almost there.
|
|
This isn't used, so it can be removed.
|
|
Given this is a central class, we should flag cases where the return
value of some functions not being used is likely a bug.
|
|
Upon further investigation, these commands allow temporary vibrations even when the "Controller Vibration" system setting is disabled. As a result, vibrations are allowed when either the system setting or this flag is set to true. Therefore, we can only block vibrations when both flags are set to false.
|
|
|
|
|
|
Previously we used a vibration filter that filters out amplitudes close to each other. It turns out there are cases where this results into vibrations that are too inaccurate. Remove this and move the 100Hz vibration filter (Only allowing a maximum of 100 vibrations per second) from sdl_impl to npad when enable_accurate_vibrations is set to false.
|
|
|
|
A vibration device is an input device that returns an unsigned byte as status.
It represents whether the vibration device supports vibration or not.
If the status returns 1, it supports vibration. Otherwise, it does not support vibration.
|
|
Allows for enabling and modifying vibration and vibration strength per player.
Also adds a toggle for enabling/disabling accurate vibrations.
Co-authored-by: Its-Rei <kupfel@gmail.com>
|
|
This will be replaced in favor of per-player vibration strength modifiers.
|
|
The implementation of these commands seem incomplete and causes rumble in Super Mario Party to stop working since only EndPermitVibrationSession is called. Thus, these are better off being marked as a stub until this can be investigated more thoroughly.
|
|
This stops all controllers from continuously vibrating when emulation is stopped.
|
|
- Used in Super Mario Odyssey
|
|
Sending too many state changes in a short period of time can cause massive performance issues.
As a result, we have to use several heuristics to reduce the number of state changes to minimize/eliminate this performance impact while maintaining the quality of these vibrations as much as possible.
|
|
This allows setting the vibration strength percentage anywhere from 1% to 100%.
Also hooks up the remaining motion button and checkbox in the Controller Applet.
|
|
Fixes vibration in 1-2 Switch and potentially other games where they would vibrate both players' joycons at the same time.
|
|
This fixes the issue where rumble is only sent to the first controller.
Now, individual controllers can receive their own rumble commands.
|
|
Some parameters need to be doubleword aligned due to the presence of the applet_resource_user_id.
Previously, this value was invalid in many commands where it was not doubleword aligned when popped.
|
|
Reorders all HID commands in command id order.
|
|
The first u32 describes the vibration device type which is a Linear Resonant Actuator used in Nintendo Switch controller hardware.
The second u32 describes the vibration device position, in this case distinguishing between left and right vibration actuators.
Pro Controllers have 2 LRAs each that can vibrate independently of each other, which means they have 2 distinct vibration device handles to distinguish between the two actuators.
Similarly for joycons, the left joycon can be distinguished from the right joycon through the vibration device handle since each joycon has 1 LRA.
|
|
|
|
This more accurately represents the underlying type and avoids confusion with NpadType
|
|
A DeviceHandle describes a vibration device or six-axis sensor based on the npad type, npad id, and device index/position
|
|
|
|
|
|
applets/controller: Introduce additional checks for mode and caller
|
|
hle: service: caps_u: Stub GetAlbumFileList3AaeAruid.
|
|
|
|
|
|
cpu_interrupt_handler: Mark move contructor/assignment as deleted
|
|
Resolves numerous deprecation warnings throughout the codebase due to
inclusion of this header. Now building core should be significantly less
noisy (and also relying on less global state).
This also uncovered quite a few modules that were relying on indirect
includes, which have also been fixed.
|
|
The interrupt handler contains a std::atomic_bool, which isn't copyable
or movable, so the special move member functions will always be deleted,
despite being defaulted.
This can resolve warnings on clang and GCC.
|
|
|
|
|
|
Some games like Cave Story+ set invalid values in the ControllerPrivateArg's mode and caller fields.
Use other fields to determine the appropriate mode and caller should either or both fields be invalid.
|
|
|
|
video_core: dma_pusher: Remove integrity check on command lists.
|
|
settings: log value of CPU_Accuracy
|
|
|
|
- This seems to cause softlocks in Breath of the Wild.
|
