| Age | Commit message (Collapse) | Author |
|---|
|
The follow-up to e2457418dae19b889b2ad85255bb95d4cd0e4bff, which
replaces most of the includes in the core header with forward declarations.
This makes it so that if any of the headers the core header was
previously including change, then no one will need to rebuild the bulk
of the core, due to core.h being quite a prevalent inclusion.
This should make turnaround for changes much faster for developers.
|
|
As means to pave the way for getting rid of global state within core,
This eliminates kernel global state by removing all globals. Instead
this introduces a KernelCore class which acts as a kernel instance. This
instance lives in the System class, which keeps its lifetime contained
to the lifetime of the System class.
This also forces the kernel types to actually interact with the main
kernel instance itself instead of having transient kernel state placed
all over several translation units, keeping everything together. It also
has a nice consequence of making dependencies much more explicit.
This also makes our initialization a tad bit more correct. Previously we
were creating a kernel process before the actual kernel was initialized,
which doesn't really make much sense.
The KernelCore class itself follows the PImpl idiom, which allows
keeping all the implementation details sealed away from everything else,
which forces the use of the exposed API and allows us to avoid any
unnecessary inclusions within the main kernel header.
|
|
|
|
|
|
|
|
|
|
Prevents NCA-related errors from being masked into MissingProgramNCA or MissingKeyFile
|
|
Avoids the need to rebuild multiple source files if the filesystem code
headers change.
This also gets rid of a few instances of indirect inclusions being
relied upon
|
|
loader/{nca, xci}: Remove unnecessary includes and unused member variables
|
|
file_sys: Add support for registration format
|
|
We can make the enum class type compatible with fmt by providing an
overload of operator<<.
While we're at it, perform proper bounds checking. If something exceeds
the array, it should be a hard fail, because it's, without a doubt, a
programmer error in this case.
|
|
|
|
Many of these aren't necessary and will cause this file to be required
to be recompiled whenever any changes to those files are made, which
lengthens compile times for no reason.
This also removes an unused metadata variable from AppLoader_XCI
|
|
These mappings are leftovers from citra and don't apply to the Switch.
|
|
|
|
GetMessageForResultStatus takes a u16, not a size_t.
|
|
Needed to avoid mismatch filetype warnings on split NAND NCAs
|
|
Full list of new errors and descriptions in core/loader/loader.h
|
|
|
|
Add Icons and Metadata Support
|
|
|
|
|
|
|
|
|
|
Eliminates duplicate code shared between their Load methods, after all the only difference is how the romfs is handled.
|
|
XCI and Encrypted NCA Support
|
|
segment array
Using member variables for referencing the segments array increases the
size of the class in memory for little benefit. The same behavior can be
achieved through the use of accessors that just return the relevant
segment.
|
|
General moving to keep kernel object types separate from the direct
kernel code. Also essentially a preliminary cleanup before eliminating
global kernel state in the kernel code.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Avoids unwanted implicit conversions. Thankfully, given the large amount
of cleanup in past PRs, only this tiny amount is left over to cover.
|
|
loader: Minor cleanup
|
|
linker: Remove unused parameter from WriteRelocations()
|
|
RealVfsFile inherits from VfsFile, the instance from std::make_shared is
already compatible with the function argument type, making the copy
constructor call unnecessary.
|
|
is_jump_relocation is never used within the function, so we can just
remove it.
|
|
It's sufficient to use a forward declaration instead of a direct
inclusion here.
|
|
Makes the code more uniform, and also braces cases where the body of an
unbraced conditional travels more than one line.
|
|
Makes it consistent with the other Apploader constructors, and prevents
implicit conversions.
|
|
This isn't used anywhere in the header.
|
|
Cleanup
Review fixes
|
|
Avoids unnecessary construction of std::string instances where
applicable.
|
|
This avoids a truncating cast on size. I doubt we'd ever traverse a
directory this large, however we also shouldn't truncate sizes away.
|
|
Loader: Only print the module names and addresses if they actually exist.
|
|
|
|
filesys/loader: std::move VirtualFile instances in constructors where applicable
|
