aboutsummaryrefslogtreecommitdiff
path: root/src/core/hle/service
AgeCommit message (Collapse)Author
2020-12-09Merge pull request #5142 from comex/xx-poll-eventsRodrigo Locatti
network, sockets: Replace `POLL_IN`, `POLL_OUT`, etc. constants with an `enum class PollEvents`
2020-12-08Merge pull request #5166 from lioncash/log-castbunnei
core: Remove unnecessary enum casts in log calls
2020-12-08Merge pull request #5135 from Morph1984/applets-shadowbunnei
applets: Resolve variable shadowing
2020-12-07core: Remove unnecessary enum casts in log callsLioncash
Follows the video core PR. fmt doesn't require casts for enum classes anymore, so we can remove quite a few casts.
2020-12-07controller: Use std::move within ConvertToFrontendParameters()Lioncash
Avoids unnecessary copies.
2020-12-07controller: Avoid unnecessary copies in ConfigurationComplete()Lioncash
Avoids unnecessary 1072 byte copies when querying info about controllers.
2020-12-06Merge pull request #5148 from comex/xx-unused-fieldsbunnei
core: Mark unused fields as [[maybe_unused]]
2020-12-06Merge pull request #5154 from comex/xx-ipcbunnei
hle: Type check ResponseBuilder::Push arguments, and fix use in vi.cpp
2020-12-07Merge pull request #5147 from comex/xx-purevirtLC
nvdrv: Remove useless re-declaration of pure virtual methods that were already declared in the superclass
2020-12-06network, sockets: Replace `POLL_IN`, `POLL_OUT`, etc. constants with an ↵comex
`enum class PollEvents` Actually, two enum classes, since for some reason there are two separate yet identical `PollFD` types used in the codebase. I get that one is ABI-compatible with the Switch while the other is an abstract type used for the host, but why not use `WSAPOLLFD` directly for the latter? Anyway, why make this change? Because on Apple platforms, `POLL_IN`, `POLL_OUT`, etc. (with an underscore) are defined as macros in <sys/signal.h>. (This is inherited from FreeBSD.) So defining a variable with the same name causes a compile error. I could just rename the variables, but while I was at it I thought I might as well switch to an enum for stronger typing. Also, change the type used for values copied directly to/from the `events` and `revents` fields of the host *native* `pollfd`/`WSASPOLLFD`, from `u32` to `short`, as `short` is the correct canonical type on both Unix and Windows.
2020-12-06hle: Type check ResponseBuilder::Push arguments, and fix use in vi.cppcomex
- Add a type check so that calling Push with an invalid type produces a compile error rather than a linker error. - vi.cpp was calling Push with a variable of type `std::size_t`. There's no explicit overload for `size_t`, but there is one for `u64`, which on most platforms is the same type as `size_t`. On macOS, however, it isn't: both types are 64 bits, but `size_t` is `unsigned long` and `u64` is `unsigned long long`. Regardless, it makes more sense to explicitly use `u64` here instead of `size_t`.
2020-12-06core: Mark unused fields as [[maybe_unused]]comex
2020-12-06boxcat: Avoid unnecessary object copycomex
2020-12-06nvdrv: Remove useless re-declaration of pure virtual methods that were ↵comex
already declared in the superclass
2020-12-05applets: Resolve variable shadowingMorph
2020-11-29core: arm: Implement InvalidateCacheRange for CPU cache invalidation.bunnei
2020-11-28Merge pull request #4998 from Morph1984/bioshock-patchbunnei
hid: Check if applet_resource exists in InitializeVibrationDevice
2020-11-28Add missing types to NpadCommunicationModegerman
2020-11-28Merge pull request #5021 from german77/StubCommunicationModebunnei
HID: Stub set and get NpadCommunicationMode
2020-11-27savedata_factory: Eliminate usage of the global system instanceLioncash
Now there's only two meaningful instances left in core.
2020-11-26Stub set and get NpadCommunicationModegerman
2020-11-26service: Eliminate usages of the global system instanceLioncash
Completely removes all usages of the global system instance within the services code by passing in the using system instance to the services.
2020-11-26Merge pull request #4975 from comex/invalid-syncpoint-idbunnei
nvdrv, video_core: Don't index out of bounds when given invalid syncpoint ID
2020-11-25Merge pull request #4981 from ogniK5377/ioctl-ctrlbunnei
nvservices: Reintroducee IoctlCtrl
2020-11-25hid: Check if applet_resource exists in InitializeVibrationDeviceMorph
2020-11-24service: am: Implement ExecuteProgram and required stubs.bunnei
- This is used by Super Mario 3D All-Stars.
2020-11-24hle: services: Fix a crash with improper NVFlinger lifetime management. (#4977)bunnei
* hle: services: Fix a crash with improper NVFlinger lifetime management. - This crash would happen when attempting to shutdown yuzu early on in boot.
2020-11-24nvdrv, video_core: Don't index out of bounds when given invalid syncpoint IDcomex
- Use .at() instead of raw indexing when dealing with untrusted indices. - For the special case of WaitFence with syncpoint id UINT32_MAX, instead of crashing, log an error and ignore. This is what I get when running Super Mario Maker 2.
2020-11-24nvservices: Reintroducee IoctlCtrlChloe Marcec
Fixes regression caused by #4907 which caused games like Breath of the Wild 1.0.0 not to boot.
2020-11-21Merge pull request #4944 from lioncash/system-rembunnei
patch_manager: Remove usages of the global system instance
2020-11-20Merge pull request #4907 from ogniK5377/nvdrv-cleanupbunnei
core: Make nvservices more standardized
2020-11-20olsc: Move member initialization to after member functions.bunnei
2020-11-19hle: service: Stub OLSC Initialize and SetSaveDataBackupSettingEnabled ↵bunnei
functions. - Used by Animal Cross: New Horizons v1.6.0 update, minimal stub gets this update working.
2020-11-18patch_manager: Remove usages of the global system instanceLioncash
With this, only 19 usages of the global system instance remain within the core library. We're almost there.
2020-11-15hid: Reimplement Begin/EndPermitVibrationSessionMorph
Upon further investigation, these commands allow temporary vibrations even when the "Controller Vibration" system setting is disabled. As a result, vibrations are allowed when either the system setting or this flag is set to true. Therefore, we can only block vibrations when both flags are set to false.
2020-11-15controllers/npad: Load input devices on initMorph
2020-11-15general: Fix compiler warnings on linux and miscellaneous changesMorph
2020-11-15controllers/npad: Remove the old vibration filterMorph
Previously we used a vibration filter that filters out amplitudes close to each other. It turns out there are cases where this results into vibrations that are too inaccurate. Remove this and move the 100Hz vibration filter (Only allowing a maximum of 100 vibrations per second) from sdl_impl to npad when enable_accurate_vibrations is set to false.
2020-11-15hid: Implement InitializeVibrationDevice and IsVibrationDeviceMountedMorph
2020-11-15input_common: Add VibrationDevice and VibrationDeviceFactoryMorph
A vibration device is an input device that returns an unsigned byte as status. It represents whether the vibration device supports vibration or not. If the status returns 1, it supports vibration. Otherwise, it does not support vibration.
2020-11-15configure_input: Add per-player vibrationMorph
Allows for enabling and modifying vibration and vibration strength per player. Also adds a toggle for enabling/disabling accurate vibrations. Co-authored-by: Its-Rei <kupfel@gmail.com>
2020-11-15settings: Remove global vibration strength modifierMorph
This will be replaced in favor of per-player vibration strength modifiers.
2020-11-15hid: Mark Begin/EndPermitVibrationSession as stubsMorph
The implementation of these commands seem incomplete and causes rumble in Super Mario Party to stop working since only EndPermitVibrationSession is called. Thus, these are better off being marked as a stub until this can be investigated more thoroughly.
2020-11-15controllers/npad: Send an empty vibration on destruction/deactivationMorph
This stops all controllers from continuously vibrating when emulation is stopped.
2020-11-15hid: Stub IsVibrationDeviceMountedMorph
- Used in Super Mario Odyssey
2020-11-15controllers/npad: Add heuristics to reduce rumble state changesMorph
Sending too many state changes in a short period of time can cause massive performance issues. As a result, we have to use several heuristics to reduce the number of state changes to minimize/eliminate this performance impact while maintaining the quality of these vibrations as much as possible.
2020-11-15configure_input: Hook up the vibration percentage spinboxMorph
This allows setting the vibration strength percentage anywhere from 1% to 100%. Also hooks up the remaining motion button and checkbox in the Controller Applet.
2020-11-15controllers/npad: Stop games from vibrating incorrect controllersMorph
Fixes vibration in 1-2 Switch and potentially other games where they would vibrate both players' joycons at the same time.
2020-11-15hid: Fix controller rumble based on new researchMorph
This fixes the issue where rumble is only sent to the first controller. Now, individual controllers can receive their own rumble commands.
2020-11-15hid: Pop a struct of parameters instead of popping individual parametersMorph
Some parameters need to be doubleword aligned due to the presence of the applet_resource_user_id. Previously, this value was invalid in many commands where it was not doubleword aligned when popped.