aboutsummaryrefslogtreecommitdiff
path: root/src/core/hle/service/filesystem
AgeCommit message (Collapse)Author
2019-06-28fsp-srv: Implement GetAccessLogVersionInfoZach Hilman
Returns some misc. data about logging to help the game determine if it should log.
2019-06-28fsp-srv: Implement OutputAccessLogToSdCardZach Hilman
Allows games to log data to the SD.
2019-04-15Merge pull request #2382 from lioncash/tablebunnei
service: Update service function tables
2019-04-11service: Update service function tablesLioncash
Updates function tables based off information from SwitchBrew.
2019-04-10fsp_srv: Remove unnecessary parameter popping in IDirectory's Read()Lioncash
IDirectory's Read() function doesn't take any input parameters. It only uses the output parameters that we already provide.
2019-04-10fsp_srv: Log out option values in IFile's Read and Write functionsLioncash
These indicate options that alter how a read/write is performed. Currently we don't need to handle these, as the only one that seems to be used is for writes, but all the custom options ever seem to do is immediate flushing, which we already do by default.
2019-04-09Merge pull request #1957 from DarkLordZach/title-providerbunnei
file_sys: Provide generic interface for accessing game data
2019-04-05Merge pull request #2339 from lioncash/rankbunnei
service/fsp_srv: Update SaveDataInfo and SaveDataDescriptor structs
2019-04-05service/fsp_srv: Don't pass SaveDataDescriptor instances by value.Lioncash
Passing around a 64 byte data struct by value is kind of wasteful, instead pass a reference to the struct.
2019-04-05service/fsp_srv: Remove unnecessary unknown member in OpenSaveDataFileSystemLioncash
The unknown member here is actually padding due to being passed as a struct. We can do the same, and remove the need to pop a padding word.
2019-04-05service/fsp_srv: Update SaveDataInfo and SaveDataDescriptor structsLioncash
I realized that I updated the documentation on SwitchBrew a while ago, but never actually updated the structs within yuzu.
2019-04-05Merge pull request #2338 from lioncash/fsbunnei
filesystem: Use a std::string_view in OpenFile()
2019-04-04filesystem: Use a std::string_view in OpenFile()Lioncash
Rather than make a full copy of the path, we can just use a string view and truncate the viewed portion of the string instead of creating a totally new truncated string.
2019-04-04hle/service: Resolve unused variable warningsLioncash
In several places, we have request parsers where there's nothing to really parse, simply because the HLE function in question operates on buffers. In these cases we can just remove these instances altogether. In the other cases, we can retrieve the relevant members from the parser and at least log them out, giving them some use.
2019-03-26core: Port current uses of RegisteredCache to ContentProviderZach Hilman
2019-03-18fsp_srv: Unstub SetCurrentProcessLioncash
This just acts as a basic setter for a given PID value and performs no further checking, so we can just store the passed in value.
2019-01-29service/fsp-srv: Update function tablesLioncash
Updates function tables based off information provided by SwitchBrew.
2018-12-27filesystem: Populate save data sizes from control dataZach Hilman
2018-12-12Merge pull request #1891 from DarkLordZach/istorage-getsizeMat M
fsp_srv: Implement IStorage::GetSize
2018-12-10fsp_srv: Implement IStorage::GetSizeZach Hilman
Takes no input and returns the size as a u64. Needed by Katamari Damacy Reroll to boot.
2018-12-09service/fsp_srv: Correct returned value in GetGlobalAccessLogMode()Lioncash
Based off RE, the backing code only ever seems to use 0-2 as the range of values 1 being a generic log enable, with 2 indicating logging should go to the SD card. These are used as a set of flags internally. Given we only care about receiving the log in general, we can just always signify that we want logging in general.
2018-12-04Merge pull request #1704 from DarkLordZach/oss-sysarchivebunnei
file_sys: Implement open source system archives
2018-12-03Merge pull request #1835 from lioncash/cache-globalbunnei
filesystem: De-globalize registered_cache_union
2018-12-01filesystem: De-globalize registered_cache_unionLioncash
We can just return a new instance of this when it's requested. This only ever holds pointers to the existing registed caches, so it's not a large object. Plus, this also gets rid of the need to keep around a separate member function just to properly clear out the union. Gets rid of one of five globals in the filesystem code.
2018-11-30service/fsp_srv: Implement CleanDirectoryRecursivelyLioncash
This is the same behavior-wise as DeleteDirectoryRecursively, with the only difference being that it doesn't delete the top level directory in the hierarchy, so given: root_dir/ - some_dir/ - File.txt - OtherFile.txt The end result is just: root_dir/
2018-11-27Reworked svcs slightly, improved error messages in AM and fsp_srvDavid Marcec
2018-11-26Changed logging to be "Log before execution", Added more error logging, all ↵David Marcec
services should now log on some level
2018-11-18filesystem: Clear registered union paths on factory creationZach Hilman
2018-11-16Merge pull request #1632 from DarkLordZach/keys-manager-optimizationsbunnei
game_list: Optimize game list refresh
2018-11-16file_sys/errors: Extract FS-related error codes to file_sys/errors.hLioncash
Keeps filesystem-related error codes in one spot.
2018-11-15fsp_srv: Add support for using open source archive if not found in NANDZach Hilman
2018-11-15Merge pull request #1618 from DarkLordZach/dump-nsobunnei
patch_manager: Add support for dumping uncompressed NSOs
2018-11-01filesystem: Cache RegisteredCacheUnion instead of constructing on demandZach Hilman
Prevents unnecessary re-reads of the metadata and unnecessary temporary objects.
2018-10-29ns: Implement command 400: GetApplicationControlDataZach Hilman
Returns the raw NACP bytes and the raw icon bytes into a title-provided buffer. Pulls from Registration Cache for control data, returning all zeros should it not exist.
2018-10-29bis_factory: Add getter for mod dump root for a title IDZach Hilman
Equates to yuzu_dir/dump/<title id>/
2018-10-29fsp_srv: Implement ISaveDataInfoReaderZach Hilman
An object to read SaveDataInfo objects, which describe a unique save on the system. This implementation iterates through all the directories in the save data space and uses the paths to reconstruct the metadata.
2018-10-29fsp_srv: Implement command 61: OpenSaveDataInfoReaderBySaveDataSpaceIdZach Hilman
Needed by Checkpoint. Returns an object that can iterate through all savedata on the system.
2018-10-29savedata_factory: Expose accessors for SaveDataSpaceZach Hilman
2018-10-27service/filesystem: Add DirectoryDelete & DirectoryDeleteRecursivelyDeeJayBro
2018-10-17fsp_srv: Apply patches to Data storage in OpenDataStorageByDataIdZach Hilman
2018-10-16file_sys/registered_cache: Use unique_ptr and regular pointers instead of ↵Lioncash
shared_ptrs where applicable The data retrieved in these cases are ultimately chiefly owned by either the RegisteredCache instance itself, or the filesystem factories. Both these should live throughout the use of their contained data. If they don't, it should be considered an interface/design issue, and using shared_ptr instances here would mask that, as the data would always be prolonged after the main owner's lifetime ended. This makes the lifetime of the data explicit and makes it harder to accidentally create cyclic references. It also makes the interface slightly more flexible than the previous API, as a shared_ptr can be created from a unique_ptr, but not the other way around, so this allows for that use-case if it ever becomes necessary in some form.
2018-10-13filesystem: Make CreateFactories() and InstallInterface() take a ↵Lioncash
VfsFilesystem instance by reference Neither of these functions alter the ownership of the provided pointer, so we can simply make the parameters a reference rather than a direct shared pointer alias. This way we also disallow passing incorrect memory values like nullptr.
2018-10-05romfs_factory: Extract packed update setter to new functionZach Hilman
2018-10-02services/fsp_srv: Amend service function tableLioncash
Adds new functions that have been given names to the table. Information is based off what is provided on Switchbrew.
2018-09-21filesystem: Add LayeredFS VFS directory getterZach Hilman
2018-09-19Fixed GetAccountId stub, Added error code for OpenDirectory and added ↵David Marcec
ActivateNpadWithRevision With these, `Nintendo Entertainment System - Nintendo Switch Online` loads
2018-09-10hle/service: Default constructors and destructors in the cpp file where ↵Lioncash
applicable When a destructor isn't defaulted into a cpp file, it can cause the use of forward declarations to seemingly fail to compile for non-obvious reasons. It also allows inlining of the construction/destruction logic all over the place where a constructor or destructor is invoked, which can lead to code bloat. This isn't so much a worry here, given the services won't be created and destroyed frequently. The cause of the above mentioned non-obvious errors can be demonstrated as follows: ------- Demonstrative example, if you know how the described error happens, skip forwards ------- Assume we have the following in the header, which we'll call "thing.h": \#include <memory> // Forward declaration. For example purposes, assume the definition // of Object is in some header named "object.h" class Object; class Thing { public: // assume no constructors or destructors are specified here, // or the constructors/destructors are defined as: // // Thing() = default; // ~Thing() = default; // // ... Some interface member functions would be defined here private: std::shared_ptr<Object> obj; }; If this header is included in a cpp file, (which we'll call "main.cpp"), this will result in a compilation error, because even though no destructor is specified, the destructor will still need to be generated by the compiler because std::shared_ptr's destructor is *not* trivial (in other words, it does something other than nothing), as std::shared_ptr's destructor needs to do two things: 1. Decrement the shared reference count of the object being pointed to, and if the reference count decrements to zero, 2. Free the Object instance's memory (aka deallocate the memory it's pointing to). And so the compiler generates the code for the destructor doing this inside main.cpp. Now, keep in mind, the Object forward declaration is not a complete type. All it does is tell the compiler "a type named Object exists" and allows us to use the name in certain situations to avoid a header dependency. So the compiler needs to generate destruction code for Object, but the compiler doesn't know *how* to destruct it. A forward declaration doesn't tell the compiler anything about Object's constructor or destructor. So, the compiler will issue an error in this case because it's undefined behavior to try and deallocate (or construct) an incomplete type and std::shared_ptr and std::unique_ptr make sure this isn't the case internally. Now, if we had defaulted the destructor in "thing.cpp", where we also include "object.h", this would never be an issue, as the destructor would only have its code generated in one place, and it would be in a place where the full class definition of Object would be visible to the compiler. ---------------------- End example ---------------------------- Given these service classes are more than certainly going to change in the future, this defaults the constructors and destructors into the relevant cpp files to make the construction and destruction of all of the services consistent and unlikely to run into cases where forward declarations are indirectly causing compilation errors. It also has the plus of avoiding the need to rebuild several services if destruction logic changes, since it would only be necessary to recompile the single cpp file.
2018-09-04bktr: Fix bucket overlap errorZach Hilman
2018-09-04registration: Add RegisteredCacheUnionZach Hilman
Aggregates multiple caches into one interface
2018-09-02Merge pull request #1213 from DarkLordZach/octopath-fsbunnei
filesystem/maxwell_3d: Various changes to boot Project Octopath Traveller