| Age | Commit message (Collapse) | Author |
|---|
|
crypto/key_manager: Remove unused variable in GetTicketblob()
|
|
We can just return a new instance of this when it's requested. This only
ever holds pointers to the existing registed caches, so it's not a large
object. Plus, this also gets rid of the need to keep around a separate
member function just to properly clear out the union.
Gets rid of one of five globals in the filesystem code.
|
|
|
|
* get rid of boost::optional
* Remove optional references
* Use std::reference_wrapper for optional references
* Fix clang format
* Fix clang format part 2
* Adressed feedback
* Fix clang format and MacOS build
|
|
Crypto revisions are hex numbers and this function only checks if the string is valid for stoul in base 16, so it should be isxdigit.
|
|
|
|
Fixes a fatal crash on start when deriving keys.
|
|
|
|
DecryptPackage2()
We can just reserve the memory then perform successive insertions
instead of needing to use memcpy. This also avoids the need to zero out
the output vector's memory before performing the insertions.
We can also std::move the output std::vector into the destination so
that we don't need to make a completely new copy of the vector, getting
rid of an unnecessary allocation.
Additionally, we can use iterators to determine the beginning and end
ranges of the std::vector instances that comprise the output vector, as
the end of one range just becomes the beginning for the next successive
range, and since std::vector's iterator constructor copies data within
the range [begin, end), this is more straightforward and gets rid of the
need to have an offset variable that keeps getting incremented to
determine where to do the next std::memcpy.
|
|
Aside from emplacing elements into the map, the map itself is never
actually queried for contained data.
|
|
These are only ever read from, so we don't need to make a copy of all
the keys here.
|
|
Given it's only used in one spot and has a fairly generic name, we can
just specify it directly in the function call. This also the benefit of
automatically moving it.
|
|
Commented out code shouldn't be left in without a reason indicating why
in a comment.
|
|
|
|
Instead, we can make it part of the type and make named variables for
them, so they only require one definition (and if they ever change for
whatever reason, they only need to be changed in one spot).
|
|
Given the VirtualFile instance isn't stored into the class as a data
member, or written to, this can just be turned into a const reference,
as the constructor doesn't need to make a copy of it.
|
|
Orders the members in the exact order they would be initialized. This
also prevents compiler warnings about this sort of thing.
|
|
Gets unused includes out of the headers and moves them into the cpp file
if they're used there instead.
|
|
back_inserter
If the data is unconditionally being appended to the back of a
std::vector, we can just directly insert it there without the need to
insert all of the elements one-by-one with a std::back_inserter.
|
|
If a conditional (or it's body) travels more than one line, it should be
braced.
|
|
Given the filesystem should always be assumed to be volatile, we should
check and bail out if a seek operation isn't successful. This'll prevent
potentially writing/returning garbage data from the function in rare
cases.
This also allows removing a check to see if an offset is within the
bounds of a file before perfoming a seek operation. If a seek is
attempted beyond the end of a file, it will fail, so this essentially
combines two checks into one in one place.
|
|
Given the file is opened a few lines above and no operations are done,
other than check if the file is in a valid state, the read/write pointer
will always be at the beginning of the file.
|
|
x
|
|
Keeps track of system files for key derivation
|
|
|
|
Derives titlekeys
|
|
Derives master keys, game encryption keys, and package1/2 keys
|
|
|
|
TSEC, SBK, BIS, and other Sources for proper derivation
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Reduces code
|
|
Issues with block size are fixed by making all reads minimum length of 0x10
|
|
|
|
Eliminated duplicate code and adds support for Rev1+ carts
|
|
|
|
Cuts down on include dependencies, resulting in less files that need to
be rebuilt when certain things are changed.
|
|
|
|
|
|
On call to WriteKeyToFile, so that the autogenerated file can be written.
|
|
|
|
|
|
Stored in a separate file than manual keys.
|
|
|
|
Should make key gets marginally faster.
|
|
|
