aboutsummaryrefslogtreecommitdiff
path: root/src/audio_core
AgeCommit message (Collapse)Author
2019-03-09audio_core/cubeb_sink: Convert _MSC_VER ifdefs to _WIN32Lioncash
This behavior also needs to be visible for MinGW builds as well.
2019-02-27audio_core/cubeb_sink: Ensure COM is initialized on Windows prior to calling ↵Lioncash
cubeb_init cubeb now requires that COM explicitly be initialized on the thread prior to calling cubeb_init.
2019-02-27audio_core/audio_renderer: Name previously unknown parameters of ↵Lioncash
AudioRendererParameter Provides names for previously unknown entries (aside from the two u8 that appear to be padding bytes, and a single word that also appears to be reserved or padding). This will be useful in subsequent changes when unstubbing behavior related to the audio renderer services.
2019-02-25audio_core/cubeb_sink: Initialize CubebSinkStream's last_frame data memberLioncash
Ensures that all member variables are initialized in a deterministic manner across the board.
2019-02-25audio_core/cubeb_sink: Add override specifier to destructorLioncash
CubebSinkStream inherits from a base class with a virtual destructor, so override can be appended to CubebSinkStream's destructor.
2019-02-25audio_core/cubeb_sink: Resolve variable shadowing warnings in SamplesInQueueLioncash
The name of the parameter was shadowing the member variable of the same name. Instead, alter the name of the parameter to prevent said shadowing.
2019-02-25audio_core/codec: Resolve truncation warnings within DecodeADPCMLioncash
The assignments here were performing an implicit truncation from int to s16. Make it explicit that this is desired behavior.
2019-02-16audio_core/buffer: Make const and non-const getter for samples consistentLioncash
This way proper const/non-const selection can occur.
2019-02-15core_timing: Convert core timing into a classLioncash
Gets rid of the largest set of mutable global state within the core. This also paves a way for eliminating usages of GetInstance() on the System class as a follow-up. Note that no behavioral changes have been made, and this simply extracts the functionality into a class. This also has the benefit of making dependencies on the core timing functionality explicit within the relevant interfaces.
2019-02-12core_timing: Rename CoreTiming namespace to Core::TimingLioncash
Places all of the timing-related functionality under the existing Core namespace to keep things consistent, rather than having the timing utilities sitting in its own completely separate namespace.
2019-01-26dsp_interface: fix sound being played while volume is 0fearlessTobi
According to documentation, if the argument of std::exp is zero, one is returned. However we want the return value to be also zero in this case so no audio is played.
2019-01-14audio_core: remove unnecessary spaces on commentsOtávio Pace
2018-12-28audio_core: Convert LOG_CRITICAL + UNREACHABLE over to ↵Lioncash
UNIMPLEMENTED/UNIMPLEMENTED_MSG These two macros being used in tandem were used prior to the introduction of UNIMPLEMENTED and UNIMPLEMENTED_MSG. This provides equivalent behavior, just with less typing/reading involved.
2018-12-14Merge pull request #1902 from lioncash/audiobunnei
audio_core: Make g_sink_details internally linked
2018-12-13audio_core: Make g_sink_details internally linkedLioncash
We can hide the direct array from external view and instead provide functions to retrieve the necessary info. This has the benefit of completely hiding the makeup of the SinkDetails structure from the rest of the code. Given that this makes the array hidden, we can also make the array constexpr by altering the members slightly. This gets rid of several static constructor calls related to std::vector and std::function. Now we don't have heap allocations here that need to occur before the program can even enter main(). It also has the benefit of saving a little bit of heap space, but this doesn't matter too much, since the savings in that regard are pretty tiny.
2018-12-06Avoid (expensive) audio interpolation when sample rates already matchheapo
2018-11-29core: Port all current usages of Event to Readable/WritableEventZach Hilman
2018-11-13audio_core/audio_renderer: Fix typo in AuxInfo member nameLioncash
2018-11-06microprofile: Drop ReleaseActiveBuffer scope.Markus Wick
This was created with the unfinished resampling PR in mind. As the resampling is now on the audio thread, we don't need to care about this here any more.
2018-10-29time_stretch: Switch to values of CitrafearlessTobi
2018-10-27cubeb_sink: ignore null-name device when selectingWeiyi Wang
We already ignore them on listing devices. We should do the same when selecting devices. This fix a crash when opening a specific device while there is a null device in the list
2018-10-24time_stretch: Remove unused m_channel_count member variableLioncash
This is only stored to, but never read from.
2018-10-09EffectOutStatus padding is now in hexDavid Marcec
2018-10-07Fixups for softlockDavid Marcec
2018-10-07Fixed missing returnDavid Marcec
Softlock explanation: after effects are initialized in smo, nothing actually changes the state. It expects the state to always be initialized. With the previous testing, updating the states much like how we handle the memory pools continue to have the softlock(which is why I said it probably wasn't effects) after further examination it seems like effects need to be initialized but the state remains unchanged until further notice. For now, assertions are added for the aux buffers to see if they update, unable to check as I haven't gotten smo to actually update them yet.
2018-10-07Fixed smo softlockDavid Marcec
2018-09-23stream: Preserve enum class type in GetState()Lioncash
Preserves the meaning/type-safetiness of the stream state instead of making it an opaque u32. This makes it usable for other things outside of the service HLE context.
2018-09-23Added audren:u#GetAudioRendererStateDavid Marcec
2018-09-20Logging: Change the TimeStretch::Process log from debug to trace level.Subv
This function is called too many times and makes the debug logging basically unusable due to the spam.
2018-09-17time_stretch: Remove unused <array> includeLioncash
This isn't used within this header and isn't necessary.
2018-09-17stream: Replace includes with forward declarations where applicableLioncash
Avoids propagating includes in headers where it's not necessary to do so.
2018-09-17audio_renderer: Replace includes with forward declarations where applicableLioncash
Avoids including unnecessary headers within the audio_renderer.h header, lessening the likelihood of needing to rebuild source files including this header if they ever change. Given std::vector allows forward declaring contained types, we can move VoiceState to the cpp file and hide the implementation entirely.
2018-09-17Merge pull request #1314 from lioncash/castbunnei
audio_core/time_stretch: Silence truncation warnings in Process()
2018-09-17Merge pull request #1321 from lioncash/audio-shadowbunnei
cubeb_sink: Get rid of variable shadowing within CubebSink's constructor
2018-09-17Merge pull request #1320 from lioncash/namebunnei
cubeb_sink: Correct context name in ListCubebSinkDevices()
2018-09-15Port #4182 from Citra: "Prefix all size_t with std::"fearlessTobi
2018-09-14cubeb_sink: Get rid of variable shadowing within CubebSink's constructorLioncash
The parameter of the lambda was shadowing the variable that was being assigned to.
2018-09-14cubeb_sink: Correct context name in ListCubebSinkDevices()Lioncash
This ain't Citra.
2018-09-13audio_core/time_stretch: Silence truncation warnings in Process()Lioncash
The SoundTouch API only accepts uint amount of samples.
2018-09-12Merge pull request #1298 from lioncash/viewbunnei
audio_core/sink_details: Change std::string parameter into std::string_view
2018-09-12Merge pull request #1163 from FearlessTobi/add-audio-stretchingbunnei
audio_core: Add audio stretching support
2018-09-12audio_core: Flush stream when not playing anythingMerryMage
2018-09-11audio_core/sink_details: Change std::string parameter into std::string_viewLioncash
The given string is only ever used for lookup and comparison, so we can just utilize a non-owning view to string data here
2018-09-09cubeb_sink: Downsample arbitrary number of channelsMerryMage
2018-09-08cubeb_sink: Perform audio stretchingMerryMage
2018-09-08audio_core: Add audio stretcherMerryMage
2018-09-08cubeb_sink: Hold last available value instead of writing zerosMerryMage
This reduces clicking in output audio should we underrun.
2018-09-08cubeb_sink: Use RingBufferMerryMage
2018-09-08Add audio stretching supportfearlessTobi
2018-09-08audio_renderer: Rename AudioOut instance to audio_outMerryMage