| Age | Commit message (Collapse) | Author |
|---|
|
gl_state: Temporarily disable culling and depth test.
|
|
constructor
Avoids unnecessary atomic reference count incrementing and decrementing
|
|
a literal
This is simply a basic value check as opposed to potentially doing
string based operations (unlikely, but still, avoiding it is free).
|
|
This was just an artifact missed during PR review.
|
|
Prevents implicit conversions.
|
|
Gets rid of relying on indirect inclusions.
|
|
|
|
Previously we were just copying the data whole-sale, even if the length
was less than the total data size. This effectively makes the
actual_data vector useless, which is likely not intended.
Instead, amend this to only copy the given length amount of data.
At the same time, we can avoid zeroing out the data before using it by
passing iterators to the constructor instead of a size.
|
|
|
|
|
|
|
|
These are unused and essentially don't provide much benefit either. If
we ever need rotation functions, these can be introduced in a way that
they don't sit in a common_* header and require a bunch of ifdefing to
simply be available
|
|
Android and macOS have supported thread_local for quite a while, but
most importantly is that we don't even really need it. Instead of using
a thread-local buffer, we can just return a non-static buffer as a
std::string, avoiding the need for that quality entirely.
|
|
Keeps the JIT assembler library up to date and ensures we don't run into
any issues that may have been resolved.
|
|
Keeps the unit-testing library up to date.
|
|
This disallows modifying the internal string buffer (which shouldn't be
modified anyhow).
|
|
externals: Update dynarmic to 5a91c94.
|
|
Easy TODO
|
|
address_arbiter: Correct assignment within an assertion statement in WakeThreads()
|
|
core/memory, core/hle/kernel: Use std::move where applicable
|
|
member function
This function doesn't alter class state.
|
|
initialized
Previously is_hfs and pfs_header members wouldn't be initialized in the
constructor, as they were stored in locals instead. This would result in
things like GetName() and PrintDebugInfo() behaving incorrectly.
While we're at it, initialize the members to deterministic values as
well, in case loading ever fails.
|
|
|
|
There's no need to take this by value when it's possible to avoid
unnecessary copies entirely like this.
|
|
|
|
|
|
Gets rid of unnecessary atomic reference count incrementing and
decrementing.
|
|
We can just use a generic lambda to avoid writing the same thing twice.
|
|
service/prepo: Add missing header guard
|
|
externals: update fmt to version 5.1.0
|
|
|
|
We can just initialize these vectors directly via their constructor.
|
|
|
|
vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()
|
|
core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()
|
|
core: Don't construct instance of Core::System, just to access its live instance
|
|
decoders: Fix calc of swizzle image_width_in_gobs.
|
|
hle/filesystem: Amend trace log in OpenSaveData() to compile in debug mode
|
|
game_list: Make ContainsAllWords an internally linked non-member function
|
|
|
|
* Virtual Filesystem
* Fix delete bug and documentate
* Review fixes + other stuff
* Fix puyo regression
|
|
variable in ZeroBlock()
|
|
WakeThreads()
This was introduced within 4f81bc4e1bd12e4df7410c6790ba818d8dbba9c0, and
considering there's no comment indicating that this is intentional, this
is very likely a bug.
|
|
|
|
GetMemoryStateName()
Without these, this would perform concatenation, which is definitely not
what we want here.
|
|
Avoids pointless copies
|
|
This makes it a compilation error to construct additional instances of
the System class directly, preventing accidental wasteful constructions
over and over.
|
|
This would result in a lot of allocations and related object
construction, just to toss it all away immediately after the call.
These are definitely not intentional, and it was intended that all of
these should have been accessing the static function GetInstance()
through the name itself, not constructed instances.
|
|
Previously, we were on 4.1.0, which was a major version behind.
|
|
Previously this wouldn't compile, since no such function named
SaveStructDebugInfo() exists.
|
