From 981e0c082d8b55e65b7bd9ef07c92ed761b88ab7 Mon Sep 17 00:00:00 2001 From: TSRBerry <20988865+TSRBerry@users.noreply.github.com> Date: Wed, 28 Jun 2023 18:54:20 +0200 Subject: [Spv.Generator] Address dotnet-format issues (#5394) * dotnet format style --severity info Some changes were manually reverted. * Restore a few unused methods and variables * Silence dotnet format IDE0052 warnings * Address or silence dotnet format IDE1006 warnings * Address or silence dotnet format CA1069 warnings * Address review comments * Address most dotnet format whitespace warnings * Run dotnet format after rebase and remove unused usings - analyzers - style - whitespace * Add comments to disabled warnings * Simplify properties and array initialization, Use const when possible, Remove trailing commas * Address IDE0251 warnings * Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas" This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e. * dotnet format whitespace after rebase * Rename Operand.cs to IOperand.cs * Update src/Spv.Generator/Module.cs Co-authored-by: Ac_K * Remove NotNullWhen attribute and use conditional access to avoid NRE * Fix duplicated enum values * Remove unread member --------- Co-authored-by: Ac_K --- src/Spv.Generator/TypeDeclarationKey.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/Spv.Generator/TypeDeclarationKey.cs') diff --git a/src/Spv.Generator/TypeDeclarationKey.cs b/src/Spv.Generator/TypeDeclarationKey.cs index e4fd5fd5..1f59331f 100644 --- a/src/Spv.Generator/TypeDeclarationKey.cs +++ b/src/Spv.Generator/TypeDeclarationKey.cs @@ -3,7 +3,7 @@ using System.Diagnostics.CodeAnalysis; namespace Spv.Generator { - internal struct TypeDeclarationKey : IEquatable + internal readonly struct TypeDeclarationKey : IEquatable { private readonly Instruction _typeDeclaration; @@ -24,7 +24,7 @@ namespace Spv.Generator public override bool Equals([NotNullWhen(true)] object obj) { - return obj is TypeDeclarationKey && Equals((TypeDeclarationKey)obj); + return obj is TypeDeclarationKey key && Equals(key); } } } -- cgit v1.2.3