From 7835968214241c37c677b6c5c82aa3353546de89 Mon Sep 17 00:00:00 2001 From: Marco Carvalho Date: Thu, 5 Oct 2023 07:41:00 -0300 Subject: Strings should not be concatenated using '+' in a loop (#5664) * Strings should not be concatenated using '+' in a loop * fix IDE0090 * undo GenerateLoadOrStore * prefer string interpolation * Update src/Ryujinx.Graphics.Shader/CodeGen/Glsl/Instructions/InstGen.cs Co-authored-by: Mary --------- Co-authored-by: Mary --- src/Ryujinx.Ui.LocaleGenerator/LocaleGenerator.cs | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'src/Ryujinx.Ui.LocaleGenerator') diff --git a/src/Ryujinx.Ui.LocaleGenerator/LocaleGenerator.cs b/src/Ryujinx.Ui.LocaleGenerator/LocaleGenerator.cs index 6fb19fae..d1b9131d 100644 --- a/src/Ryujinx.Ui.LocaleGenerator/LocaleGenerator.cs +++ b/src/Ryujinx.Ui.LocaleGenerator/LocaleGenerator.cs @@ -1,5 +1,6 @@ using Microsoft.CodeAnalysis; using System.Linq; +using System.Text; namespace Ryujinx.Ui.LocaleGenerator { @@ -15,15 +16,17 @@ namespace Ryujinx.Ui.LocaleGenerator context.RegisterSourceOutput(contents, (spc, content) => { var lines = content.Split('\n').Where(x => x.Trim().StartsWith("\"")).Select(x => x.Split(':')[0].Trim().Replace("\"", "")); - string enumSource = "namespace Ryujinx.Ava.Common.Locale;\n"; - enumSource += "internal enum LocaleKeys\n{\n"; + StringBuilder enumSourceBuilder = new(); + enumSourceBuilder.AppendLine("namespace Ryujinx.Ava.Common.Locale;"); + enumSourceBuilder.AppendLine("internal enum LocaleKeys"); + enumSourceBuilder.AppendLine("{"); foreach (var line in lines) { - enumSource += $" {line},\n"; + enumSourceBuilder.AppendLine($" {line},"); } - enumSource += "}\n"; + enumSourceBuilder.AppendLine("}"); - spc.AddSource("LocaleKeys", enumSource); + spc.AddSource("LocaleKeys", enumSourceBuilder.ToString()); }); } } -- cgit v1.2.3