From 21c9ac6240a3db3300143d1d0dd4a1070d4f576f Mon Sep 17 00:00:00 2001 From: gdkchan Date: Sat, 3 Jun 2023 20:12:18 -0300 Subject: Implement shader storage buffer operations using new Load/Store instructions (#4993) * Implement storage buffer operations using new Load/Store instruction * Extend GenerateMultiTargetStorageOp to also match access with constant offset, and log and comments * Remove now unused code * Catch more complex cases of global memory usage * Shader cache version bump * Extend global access elimination to work with more shared memory cases * Change alignment requirement from 16 bytes to 8 bytes, handle cases where we need more than 16 storage buffers * Tweak preferencing to catch more cases * Enable CB0 elimination even when host storage buffer alignment is > 16 (for Intel) * Fix storage buffer bindings * Simplify some code * Shader cache version bump * Fix typo * Extend global memory elimination to handle shared memory with multiple possible offsets and local memory --- .../IntermediateRepresentation/Instruction.cs | 8 -------- .../IntermediateRepresentation/StorageKind.cs | 7 ++++++- 2 files changed, 6 insertions(+), 9 deletions(-) (limited to 'src/Ryujinx.Graphics.Shader/IntermediateRepresentation') diff --git a/src/Ryujinx.Graphics.Shader/IntermediateRepresentation/Instruction.cs b/src/Ryujinx.Graphics.Shader/IntermediateRepresentation/Instruction.cs index f7afe507..aecb6724 100644 --- a/src/Ryujinx.Graphics.Shader/IntermediateRepresentation/Instruction.cs +++ b/src/Ryujinx.Graphics.Shader/IntermediateRepresentation/Instruction.cs @@ -79,10 +79,8 @@ namespace Ryujinx.Graphics.Shader.IntermediateRepresentation ImageAtomic, IsNan, Load, - LoadGlobal, LoadLocal, LoadShared, - LoadStorage, Lod, LogarithmB2, LogicalAnd, @@ -117,16 +115,10 @@ namespace Ryujinx.Graphics.Shader.IntermediateRepresentation Sine, SquareRoot, Store, - StoreGlobal, - StoreGlobal16, - StoreGlobal8, StoreLocal, StoreShared, StoreShared16, StoreShared8, - StoreStorage, - StoreStorage16, - StoreStorage8, Subtract, SwizzleAdd, TextureSample, diff --git a/src/Ryujinx.Graphics.Shader/IntermediateRepresentation/StorageKind.cs b/src/Ryujinx.Graphics.Shader/IntermediateRepresentation/StorageKind.cs index 59357443..2b5dd1de 100644 --- a/src/Ryujinx.Graphics.Shader/IntermediateRepresentation/StorageKind.cs +++ b/src/Ryujinx.Graphics.Shader/IntermediateRepresentation/StorageKind.cs @@ -11,7 +11,12 @@ namespace Ryujinx.Graphics.Shader.IntermediateRepresentation StorageBuffer, LocalMemory, SharedMemory, - GlobalMemory + GlobalMemory, + // TODO: Remove those and store type as a field on the Operation class itself. + GlobalMemoryS8, + GlobalMemoryS16, + GlobalMemoryU8, + GlobalMemoryU16 } static class StorageKindExtensions -- cgit v1.2.3