From 7c989f88bdab65dfa7783e824a180220ba829bd0 Mon Sep 17 00:00:00 2001
From: TSRBerry <20988865+TSRBerry@users.noreply.github.com>
Date: Wed, 28 Jun 2023 20:20:10 +0200
Subject: [Ryujinx.Graphics.GAL] Address dotnet-format issues (#5366)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0052 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA1069 warnings

* Address remaining dotnet format analyzer warnings

* Address review comments

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Revert formatting changes for while and for-loops

* Another rebase, another dotnet format run

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Address IDE0251 warnings

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Address review feedback

* Add trailing commas

* Remove SuppressMessage for IDE0066

* Make explicit Equals implementation implicit
---
 src/Ryujinx.Graphics.GAL/Multithreading/Model/CircularSpanPool.cs | 8 ++++----
 src/Ryujinx.Graphics.GAL/Multithreading/Model/SpanRef.cs          | 4 ++--
 src/Ryujinx.Graphics.GAL/Multithreading/Model/TableRef.cs         | 4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

(limited to 'src/Ryujinx.Graphics.GAL/Multithreading/Model')

diff --git a/src/Ryujinx.Graphics.GAL/Multithreading/Model/CircularSpanPool.cs b/src/Ryujinx.Graphics.GAL/Multithreading/Model/CircularSpanPool.cs
index 4ea1a2c7..10cab84c 100644
--- a/src/Ryujinx.Graphics.GAL/Multithreading/Model/CircularSpanPool.cs
+++ b/src/Ryujinx.Graphics.GAL/Multithreading/Model/CircularSpanPool.cs
@@ -12,9 +12,9 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Model
     /// </summary>
     class CircularSpanPool
     {
-        private ThreadedRenderer _renderer;
-        private byte[] _pool;
-        private int _size;
+        private readonly ThreadedRenderer _renderer;
+        private readonly byte[] _pool;
+        private readonly int _size;
 
         private int _producerPtr;
         private int _producerSkipPosition = -1;
@@ -83,7 +83,7 @@ namespace Ryujinx.Graphics.GAL.Multithreading.Model
         {
             int size = length * Unsafe.SizeOf<T>();
 
-            _consumerPtr = _consumerPtr + size;
+            _consumerPtr += size;
         }
     }
 }
diff --git a/src/Ryujinx.Graphics.GAL/Multithreading/Model/SpanRef.cs b/src/Ryujinx.Graphics.GAL/Multithreading/Model/SpanRef.cs
index 7dbebc76..1ed719a0 100644
--- a/src/Ryujinx.Graphics.GAL/Multithreading/Model/SpanRef.cs
+++ b/src/Ryujinx.Graphics.GAL/Multithreading/Model/SpanRef.cs
@@ -2,9 +2,9 @@
 
 namespace Ryujinx.Graphics.GAL.Multithreading.Model
 {
-    struct SpanRef<T> where T : unmanaged
+    readonly struct SpanRef<T> where T : unmanaged
     {
-        private int _packedLengthId;
+        private readonly int _packedLengthId;
 
         public SpanRef(ThreadedRenderer renderer, T[] data)
         {
diff --git a/src/Ryujinx.Graphics.GAL/Multithreading/Model/TableRef.cs b/src/Ryujinx.Graphics.GAL/Multithreading/Model/TableRef.cs
index 166aa71a..e454df21 100644
--- a/src/Ryujinx.Graphics.GAL/Multithreading/Model/TableRef.cs
+++ b/src/Ryujinx.Graphics.GAL/Multithreading/Model/TableRef.cs
@@ -1,8 +1,8 @@
 namespace Ryujinx.Graphics.GAL.Multithreading.Model
 {
-    struct TableRef<T>
+    readonly struct TableRef<T>
     {
-        private int _index;
+        private readonly int _index;
 
         public TableRef(ThreadedRenderer renderer, T reference)
         {
-- 
cgit v1.2.3