From fc20d9b925b83532a19467293a7cdcbaa4ef3d6b Mon Sep 17 00:00:00 2001 From: TSRBerry <20988865+TSRBerry@users.noreply.github.com> Date: Wed, 28 Jun 2023 18:41:38 +0200 Subject: [Ryujinx.Common] Address dotnet-format issues (#5358) * dotnet format style --severity info Some changes were manually reverted. * dotnet format analyzers --serverity info Some changes have been minimally adapted. * Restore a few unused methods and variables * Silence dotnet format IDE0060 warnings * Silence dotnet format IDE0059 warnings * Address or silence dotnet format IDE1006 warnings * Address dotnet format CA1816 warnings * Address or silence dotnet format CA2211 warnings * Silence CA1806 and CA1834 issues * Fix formatting for switch expressions * Address most dotnet format whitespace warnings * Apply dotnet format whitespace formatting A few of them have been manually reverted and the corresponding warning was silenced * Revert formatting changes for while and for-loops * Format if-blocks correctly * Run dotnet format whitespace after rebase * Run dotnet format style after rebase * Run dotnet format analyzers after rebase * Run dotnet format after rebase and remove unused usings - analyzers - style - whitespace * Add comments to disabled warnings * Remove a few unused parameters * Replace MmeShadowScratch with Array256 * Simplify properties and array initialization, Use const when possible, Remove trailing commas * Run dotnet format after rebase * Address IDE0251 warnings * Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas" This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e. * dotnet format whitespace after rebase * First dotnet format pass * Second dotnet format pass * Fix build issues * Fix StructArrayHelpers.cs * Apply suggestions from code review Co-authored-by: Ac_K * Fix return statements * Fix naming rule violations * Update src/Ryujinx.Common/Utilities/StreamUtils.cs Co-authored-by: Ac_K * Add trailing commas * Address review feedback * Address review feedback * Rename remaining type parameters to TKey and TValue * Fix manual formatting for logging levels * Fix spacing before comments --------- Co-authored-by: Ac_K --- .../Logging/Formatters/DynamicObjectFormatter.cs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src/Ryujinx.Common/Logging/Formatters/DynamicObjectFormatter.cs') diff --git a/src/Ryujinx.Common/Logging/Formatters/DynamicObjectFormatter.cs b/src/Ryujinx.Common/Logging/Formatters/DynamicObjectFormatter.cs index 6e3b0043..1ee73acd 100644 --- a/src/Ryujinx.Common/Logging/Formatters/DynamicObjectFormatter.cs +++ b/src/Ryujinx.Common/Logging/Formatters/DynamicObjectFormatter.cs @@ -7,7 +7,7 @@ namespace Ryujinx.Common.Logging.Formatters { internal static class DynamicObjectFormatter { - private static readonly ObjectPool StringBuilderPool = SharedPools.Default(); + private static readonly ObjectPool _stringBuilderPool = SharedPools.Default(); public static string? Format(object? dynamicObject) { @@ -16,7 +16,7 @@ namespace Ryujinx.Common.Logging.Formatters return null; } - StringBuilder sb = StringBuilderPool.Allocate(); + StringBuilder sb = _stringBuilderPool.Allocate(); try { @@ -26,7 +26,7 @@ namespace Ryujinx.Common.Logging.Formatters } finally { - StringBuilderPool.Release(sb); + _stringBuilderPool.Release(sb); } } @@ -48,7 +48,7 @@ namespace Ryujinx.Common.Logging.Formatters if (typeof(Array).IsAssignableFrom(prop.PropertyType)) { - Array? array = (Array?) prop.GetValue(dynamicObject); + Array? array = (Array?)prop.GetValue(dynamicObject); if (array is not null) { @@ -81,4 +81,4 @@ namespace Ryujinx.Common.Logging.Formatters sb.Append('}'); } } -} \ No newline at end of file +} -- cgit v1.2.3