From f77694e4f774c9391aad5344e70a7c8721cfedc6 Mon Sep 17 00:00:00 2001 From: gdkchan Date: Sun, 3 May 2020 19:54:50 -0300 Subject: Implement a new physical memory manager and replace DeviceMemory (#856) * Implement a new physical memory manager and replace DeviceMemory * Proper generic constraints * Fix debug build * Add memory tests * New CPU memory manager and general code cleanup * Remove host memory management from CPU project, use Ryujinx.Memory instead * Fix tests * Document exceptions on MemoryBlock * Fix leak on unix memory allocation * Proper disposal of some objects on tests * Fix JitCache not being set as initialized * GetRef without checks for 8-bits and 16-bits CAS * Add MemoryBlock destructor * Throw in separate method to improve codegen * Address PR feedback * QueryModified improvements * Fix memory write tracking not marking all pages as modified in some cases * Simplify MarkRegionAsModified * Remove XML doc for ghost param * Add back optimization to avoid useless buffer updates * Add Ryujinx.Cpu project, move MemoryManager there and remove MemoryBlockWrapper * Some nits * Do not perform address translation when size is 0 * Address PR feedback and format NativeInterface class * Remove ghost parameter description * Update Ryujinx.Cpu to .NET Core 3.1 * Address PR feedback * Fix build * Return a well defined value for GetPhysicalAddress with invalid VA, and do not return unmapped ranges as modified * Typo --- Ryujinx.HLE/HOS/Services/Time/TimeSharedMemory.cs | 31 ++++++++++++----------- 1 file changed, 16 insertions(+), 15 deletions(-) (limited to 'Ryujinx.HLE/HOS/Services/Time/TimeSharedMemory.cs') diff --git a/Ryujinx.HLE/HOS/Services/Time/TimeSharedMemory.cs b/Ryujinx.HLE/HOS/Services/Time/TimeSharedMemory.cs index f714c662..e3683076 100644 --- a/Ryujinx.HLE/HOS/Services/Time/TimeSharedMemory.cs +++ b/Ryujinx.HLE/HOS/Services/Time/TimeSharedMemory.cs @@ -1,4 +1,5 @@ using System; +using System.Runtime.CompilerServices; using System.Runtime.InteropServices; using System.Threading; using Ryujinx.HLE.HOS.Kernel.Memory; @@ -13,7 +14,7 @@ namespace Ryujinx.HLE.HOS.Services.Time { private Switch _device; private KSharedMemory _sharedMemory; - private long _timeSharedMemoryAddress; + private ulong _timeSharedMemoryAddress; private int _timeSharedMemorySize; private const uint SteadyClockContextOffset = 0x00; @@ -21,7 +22,7 @@ namespace Ryujinx.HLE.HOS.Services.Time private const uint NetworkSystemClockContextOffset = 0x80; private const uint AutomaticCorrectionEnabledOffset = 0xC8; - public void Initialize(Switch device, KSharedMemory sharedMemory, long timeSharedMemoryAddress, int timeSharedMemorySize) + public void Initialize(Switch device, KSharedMemory sharedMemory, ulong timeSharedMemoryAddress, int timeSharedMemorySize) { _device = device; _sharedMemory = sharedMemory; @@ -29,7 +30,7 @@ namespace Ryujinx.HLE.HOS.Services.Time _timeSharedMemorySize = timeSharedMemorySize; // Clean the shared memory - _device.Memory.FillWithZeros(_timeSharedMemoryAddress, _timeSharedMemorySize); + _device.Memory.ZeroFill(_timeSharedMemoryAddress, (ulong)_timeSharedMemorySize); } public KSharedMemory GetSharedMemory() @@ -86,9 +87,9 @@ namespace Ryujinx.HLE.HOS.Services.Time WriteObjectToSharedMemory(NetworkSystemClockContextOffset, 4, context); } - private T ReadObjectFromSharedMemory(long offset, long padding) + private T ReadObjectFromSharedMemory(ulong offset, ulong padding) where T : unmanaged { - long indexOffset = _timeSharedMemoryAddress + offset; + ulong indexOffset = _timeSharedMemoryAddress + offset; T result; uint index; @@ -96,31 +97,31 @@ namespace Ryujinx.HLE.HOS.Services.Time do { - index = _device.Memory.ReadUInt32(indexOffset); + index = _device.Memory.Read(indexOffset); - long objectOffset = indexOffset + 4 + padding + (index & 1) * Marshal.SizeOf(); + ulong objectOffset = indexOffset + 4 + padding + (ulong)((index & 1) * Unsafe.SizeOf()); - result = _device.Memory.ReadStruct(objectOffset); + result = _device.Memory.Read(objectOffset); Thread.MemoryBarrier(); - possiblyNewIndex = _device.Memory.ReadUInt32(indexOffset); + possiblyNewIndex = _device.Memory.Read(indexOffset); } while (index != possiblyNewIndex); return result; } - private void WriteObjectToSharedMemory(long offset, long padding, T value) + private void WriteObjectToSharedMemory(ulong offset, ulong padding, T value) where T : unmanaged { - long indexOffset = _timeSharedMemoryAddress + offset; - uint newIndex = _device.Memory.ReadUInt32(indexOffset) + 1; - long objectOffset = indexOffset + 4 + padding + (newIndex & 1) * Marshal.SizeOf(); + ulong indexOffset = _timeSharedMemoryAddress + offset; + uint newIndex = _device.Memory.Read(indexOffset) + 1; + ulong objectOffset = indexOffset + 4 + padding + (ulong)((newIndex & 1) * Unsafe.SizeOf()); - _device.Memory.WriteStruct(objectOffset, value); + _device.Memory.Write(objectOffset, value); Thread.MemoryBarrier(); - _device.Memory.WriteUInt32(indexOffset, newIndex); + _device.Memory.Write(indexOffset, newIndex); } } } -- cgit v1.2.3