From a33dc2f4919f7fdc8ea9db41c4c70c38cedfd3df Mon Sep 17 00:00:00 2001 From: mageven <62494521+mageven@users.noreply.github.com> Date: Tue, 4 Aug 2020 05:02:53 +0530 Subject: Improved Logger (#1292) * Logger class changes only Now compile-time checking is possible with the help of Nullable Value types. * Misc formatting * Manual optimizations PrintGuestLog PrintGuestStackTrace Surfaceflinger DequeueBuffer * Reduce SendVibrationXX log level to Debug * Add Notice log level This level is always enabled and used to print system info, etc... Also, rewrite LogColor to switch expression as colors are static * Unify unhandled exception event handlers * Print enabled LogLevels during init * Re-add App Exit disposes in proper order nit: switch case spacing * Revert PrintGuestStackTrace to Info logs due to #1407 PrintGuestStackTrace is now called in some critical error handlers so revert to old behavior as KThread isn't part of Guest. * Batch replace Logger statements --- Ryujinx.HLE/HOS/Services/Settings/ISettingsServer.cs | 4 ++-- Ryujinx.HLE/HOS/Services/Settings/ISystemSettingsServer.cs | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'Ryujinx.HLE/HOS/Services/Settings') diff --git a/Ryujinx.HLE/HOS/Services/Settings/ISettingsServer.cs b/Ryujinx.HLE/HOS/Services/Settings/ISettingsServer.cs index ae877c78..b2be3b31 100644 --- a/Ryujinx.HLE/HOS/Services/Settings/ISettingsServer.cs +++ b/Ryujinx.HLE/HOS/Services/Settings/ISettingsServer.cs @@ -105,7 +105,7 @@ namespace Ryujinx.HLE.HOS.Services.Settings { context.ResponseData.Write(false); - Logger.PrintStub(LogClass.ServiceSet); + Logger.Stub?.PrintStub(LogClass.ServiceSet); return ResultCode.Success; } @@ -121,7 +121,7 @@ namespace Ryujinx.HLE.HOS.Services.Settings { if (context.Request.ReceiveBuff[0].Size != 0x1000) { - Logger.PrintWarning(LogClass.ServiceSet, "Bad size"); + Logger.Warning?.Print(LogClass.ServiceSet, "Bad size"); } byte[] keyCodeMap; diff --git a/Ryujinx.HLE/HOS/Services/Settings/ISystemSettingsServer.cs b/Ryujinx.HLE/HOS/Services/Settings/ISystemSettingsServer.cs index f3113e65..da7ffa86 100644 --- a/Ryujinx.HLE/HOS/Services/Settings/ISystemSettingsServer.cs +++ b/Ryujinx.HLE/HOS/Services/Settings/ISystemSettingsServer.cs @@ -186,7 +186,7 @@ namespace Ryujinx.HLE.HOS.Services.Settings { if (stringValue.Length + 1 > replySize) { - Logger.PrintError(LogClass.ServiceSet, $"{askedSetting} String value size is too big!"); + Logger.Error?.Print(LogClass.ServiceSet, $"{askedSetting} String value size is too big!"); } else { @@ -209,11 +209,11 @@ namespace Ryujinx.HLE.HOS.Services.Settings context.Memory.Write((ulong)replyPos, settingBuffer); - Logger.PrintDebug(LogClass.ServiceSet, $"{askedSetting} set value: {nxSetting} as {nxSetting.GetType()}"); + Logger.Debug?.Print(LogClass.ServiceSet, $"{askedSetting} set value: {nxSetting} as {nxSetting.GetType()}"); } else { - Logger.PrintError(LogClass.ServiceSet, $"{askedSetting} not found!"); + Logger.Error?.Print(LogClass.ServiceSet, $"{askedSetting} not found!"); } return ResultCode.Success; -- cgit v1.2.3