From 85dbb9559ad317a657dafd24da27fec4b3f5250f Mon Sep 17 00:00:00 2001
From: Alex Barney <thealexbarney@gmail.com>
Date: Tue, 4 Dec 2018 14:23:37 -0600
Subject: Adjust naming conventions and general refactoring in HLE Project
 (#490)

* Rename enum fields

* Naming conventions

* Remove unneeded ".this"

* Remove unneeded semicolons

* Remove unused Usings

* Don't use var

* Remove unneeded enum underlying types

* Explicitly label class visibility

* Remove unneeded @ prefixes

* Remove unneeded commas

* Remove unneeded if expressions

* Method doesn't use unsafe code

* Remove unneeded casts

* Initialized objects don't need an empty constructor

* Remove settings from DotSettings

* Revert "Explicitly label class visibility"

This reverts commit ad5eb5787cc5b27a4631cd46ef5f551c4ae95e51.

* Small changes

* Revert external enum renaming

* Changes from feedback

* Remove unneeded property setters
---
 .../HOS/Services/Pctl/IParentalControlService.cs     | 20 ++++++++++----------
 .../Services/Pctl/IParentalControlServiceFactory.cs  | 14 +++++++-------
 2 files changed, 17 insertions(+), 17 deletions(-)

(limited to 'Ryujinx.HLE/HOS/Services/Pctl')

diff --git a/Ryujinx.HLE/HOS/Services/Pctl/IParentalControlService.cs b/Ryujinx.HLE/HOS/Services/Pctl/IParentalControlService.cs
index 3e9d276a..0c539aa1 100644
--- a/Ryujinx.HLE/HOS/Services/Pctl/IParentalControlService.cs
+++ b/Ryujinx.HLE/HOS/Services/Pctl/IParentalControlService.cs
@@ -6,29 +6,29 @@ namespace Ryujinx.HLE.HOS.Services.Pctl
 {
     class IParentalControlService : IpcService
     {
-        private Dictionary<int, ServiceProcessRequest> m_Commands;
+        private Dictionary<int, ServiceProcessRequest> _commands;
 
-        public override IReadOnlyDictionary<int, ServiceProcessRequest> Commands => m_Commands;
+        public override IReadOnlyDictionary<int, ServiceProcessRequest> Commands => _commands;
 
-        private bool Initialized = false;
+        private bool _initialized = false;
 
-        private bool NeedInitialize;
+        private bool _needInitialize;
 
-        public IParentalControlService(bool NeedInitialize = true)
+        public IParentalControlService(bool needInitialize = true)
         {
-            m_Commands = new Dictionary<int, ServiceProcessRequest>()
+            _commands = new Dictionary<int, ServiceProcessRequest>
             {
                 { 1, Initialize }
             };
 
-            this.NeedInitialize = NeedInitialize;
+            _needInitialize = needInitialize;
         }
 
-        public long Initialize(ServiceCtx Context)
+        public long Initialize(ServiceCtx context)
         {
-            if (NeedInitialize && !Initialized)
+            if (_needInitialize && !_initialized)
             {
-                Initialized = true;
+                _initialized = true;
             }
             else
             {
diff --git a/Ryujinx.HLE/HOS/Services/Pctl/IParentalControlServiceFactory.cs b/Ryujinx.HLE/HOS/Services/Pctl/IParentalControlServiceFactory.cs
index 157d594d..92500187 100644
--- a/Ryujinx.HLE/HOS/Services/Pctl/IParentalControlServiceFactory.cs
+++ b/Ryujinx.HLE/HOS/Services/Pctl/IParentalControlServiceFactory.cs
@@ -5,29 +5,29 @@ namespace Ryujinx.HLE.HOS.Services.Pctl
 {
     class IParentalControlServiceFactory : IpcService
     {
-        private Dictionary<int, ServiceProcessRequest> m_Commands;
+        private Dictionary<int, ServiceProcessRequest> _commands;
 
-        public override IReadOnlyDictionary<int, ServiceProcessRequest> Commands => m_Commands;
+        public override IReadOnlyDictionary<int, ServiceProcessRequest> Commands => _commands;
 
         public IParentalControlServiceFactory()
         {
-            m_Commands = new Dictionary<int, ServiceProcessRequest>()
+            _commands = new Dictionary<int, ServiceProcessRequest>
             {
                 { 0, CreateService                  },
                 { 1, CreateServiceWithoutInitialize }
             };
         }
 
-        public long CreateService(ServiceCtx Context)
+        public long CreateService(ServiceCtx context)
         {
-            MakeObject(Context, new IParentalControlService());
+            MakeObject(context, new IParentalControlService());
 
             return 0;
         }
 
-        public long CreateServiceWithoutInitialize(ServiceCtx Context)
+        public long CreateServiceWithoutInitialize(ServiceCtx context)
         {
-            MakeObject(Context, new IParentalControlService(false));
+            MakeObject(context, new IParentalControlService(false));
 
             return 0;
         }
-- 
cgit v1.2.3