From 85dbb9559ad317a657dafd24da27fec4b3f5250f Mon Sep 17 00:00:00 2001
From: Alex Barney <thealexbarney@gmail.com>
Date: Tue, 4 Dec 2018 14:23:37 -0600
Subject: Adjust naming conventions and general refactoring in HLE Project
 (#490)

* Rename enum fields

* Naming conventions

* Remove unneeded ".this"

* Remove unneeded semicolons

* Remove unused Usings

* Don't use var

* Remove unneeded enum underlying types

* Explicitly label class visibility

* Remove unneeded @ prefixes

* Remove unneeded commas

* Remove unneeded if expressions

* Method doesn't use unsafe code

* Remove unneeded casts

* Initialized objects don't need an empty constructor

* Remove settings from DotSettings

* Revert "Explicitly label class visibility"

This reverts commit ad5eb5787cc5b27a4631cd46ef5f551c4ae95e51.

* Small changes

* Revert external enum renaming

* Changes from feedback

* Remove unneeded property setters
---
 Ryujinx.HLE/HOS/Kernel/KSharedMemory.cs | 62 ++++++++++++++++-----------------
 1 file changed, 31 insertions(+), 31 deletions(-)

(limited to 'Ryujinx.HLE/HOS/Kernel/KSharedMemory.cs')

diff --git a/Ryujinx.HLE/HOS/Kernel/KSharedMemory.cs b/Ryujinx.HLE/HOS/Kernel/KSharedMemory.cs
index a440438b..0e9f8840 100644
--- a/Ryujinx.HLE/HOS/Kernel/KSharedMemory.cs
+++ b/Ryujinx.HLE/HOS/Kernel/KSharedMemory.cs
@@ -4,65 +4,65 @@ namespace Ryujinx.HLE.HOS.Kernel
 {
     class KSharedMemory
     {
-        private KPageList PageList;
+        private KPageList _pageList;
 
-        private long OwnerPid;
+        private long _ownerPid;
 
-        private MemoryPermission OwnerPermission;
-        private MemoryPermission UserPermission;
+        private MemoryPermission _ownerPermission;
+        private MemoryPermission _userPermission;
 
         public KSharedMemory(
-            KPageList        PageList,
-            long             OwnerPid,
-            MemoryPermission OwnerPermission,
-            MemoryPermission UserPermission)
+            KPageList        pageList,
+            long             ownerPid,
+            MemoryPermission ownerPermission,
+            MemoryPermission userPermission)
         {
-            this.PageList        = PageList;
-            this.OwnerPid        = OwnerPid;
-            this.OwnerPermission = OwnerPermission;
-            this.UserPermission  = UserPermission;
+            _pageList        = pageList;
+            _ownerPid        = ownerPid;
+            _ownerPermission = ownerPermission;
+            _userPermission  = userPermission;
         }
 
         public KernelResult MapIntoProcess(
-            KMemoryManager   MemoryManager,
-            ulong            Address,
-            ulong            Size,
-            KProcess         Process,
-            MemoryPermission Permission)
+            KMemoryManager   memoryManager,
+            ulong            address,
+            ulong            size,
+            KProcess         process,
+            MemoryPermission permission)
         {
-            ulong PagesCountRounded = BitUtils.DivRoundUp(Size, KMemoryManager.PageSize);
+            ulong pagesCountRounded = BitUtils.DivRoundUp(size, KMemoryManager.PageSize);
 
-            if (PageList.GetPagesCount() != PagesCountRounded)
+            if (_pageList.GetPagesCount() != pagesCountRounded)
             {
                 return KernelResult.InvalidSize;
             }
 
-            MemoryPermission ExpectedPermission = Process.Pid == OwnerPid
-                ? OwnerPermission
-                : UserPermission;
+            MemoryPermission expectedPermission = process.Pid == _ownerPid
+                ? _ownerPermission
+                : _userPermission;
 
-            if (Permission != ExpectedPermission)
+            if (permission != expectedPermission)
             {
                 return KernelResult.InvalidPermission;
             }
 
-            return MemoryManager.MapPages(Address, PageList, MemoryState.SharedMemory, Permission);
+            return memoryManager.MapPages(address, _pageList, MemoryState.SharedMemory, permission);
         }
 
         public KernelResult UnmapFromProcess(
-            KMemoryManager   MemoryManager,
-            ulong            Address,
-            ulong            Size,
-            KProcess         Process)
+            KMemoryManager   memoryManager,
+            ulong            address,
+            ulong            size,
+            KProcess         process)
         {
-            ulong PagesCountRounded = BitUtils.DivRoundUp(Size, KMemoryManager.PageSize);
+            ulong pagesCountRounded = BitUtils.DivRoundUp(size, KMemoryManager.PageSize);
 
-            if (PageList.GetPagesCount() != PagesCountRounded)
+            if (_pageList.GetPagesCount() != pagesCountRounded)
             {
                 return KernelResult.InvalidSize;
             }
 
-            return MemoryManager.UnmapPages(Address, PageList, MemoryState.SharedMemory);
+            return memoryManager.UnmapPages(address, _pageList, MemoryState.SharedMemory);
         }
     }
 }
\ No newline at end of file
-- 
cgit v1.2.3