From fe29aff266ede26d44270a39b186231dce186356 Mon Sep 17 00:00:00 2001 From: riperiperi Date: Wed, 2 Jun 2021 12:27:30 +0100 Subject: Use Quads on OpenGL host when supported. (#2331) Improves OpenGL performance on FAST RMX and Xenoblade DE/2. Will probably only work on NVIDIA GPUs, but the emulated quads path will still be valid for other GPUs. Note: SLOW RMX gets a bit faster in handheld mode. I'd recommend checking on platforms without supported host quads to make sure a GL error is actually thrown when attempting GL.Begin(PrimitiveType.Quads) --- Ryujinx.Graphics.OpenGL/HwCapabilities.cs | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'Ryujinx.Graphics.OpenGL/HwCapabilities.cs') diff --git a/Ryujinx.Graphics.OpenGL/HwCapabilities.cs b/Ryujinx.Graphics.OpenGL/HwCapabilities.cs index c994113d..97574aea 100644 --- a/Ryujinx.Graphics.OpenGL/HwCapabilities.cs +++ b/Ryujinx.Graphics.OpenGL/HwCapabilities.cs @@ -11,6 +11,7 @@ namespace Ryujinx.Graphics.OpenGL private static readonly Lazy _supportsViewportSwizzle = new Lazy(() => HasExtension("GL_NV_viewport_swizzle")); private static readonly Lazy _supportsSeamlessCubemapPerTexture = new Lazy(() => HasExtension("GL_ARB_seamless_cubemap_per_texture")); private static readonly Lazy _supportsParallelShaderCompile = new Lazy(() => HasExtension("GL_ARB_parallel_shader_compile")); + private static readonly Lazy _supportsQuads = new Lazy(SupportsQuadsCheck); private static readonly Lazy _maximumComputeSharedMemorySize = new Lazy(() => GetLimit(All.MaxComputeSharedMemorySize)); private static readonly Lazy _storageBufferOffsetAlignment = new Lazy(() => GetLimit(All.ShaderStorageBufferOffsetAlignment)); @@ -36,6 +37,7 @@ namespace Ryujinx.Graphics.OpenGL public static bool SupportsViewportSwizzle => _supportsViewportSwizzle.Value; public static bool SupportsSeamlessCubemapPerTexture => _supportsSeamlessCubemapPerTexture.Value; public static bool SupportsParallelShaderCompile => _supportsParallelShaderCompile.Value; + public static bool SupportsQuads => _supportsQuads.Value; public static bool SupportsNonConstantTextureOffset => _gpuVendor.Value == GpuVendor.Nvidia; public static bool RequiresSyncFlush => _gpuVendor.Value == GpuVendor.Amd || _gpuVendor.Value == GpuVendor.IntelWindows || _gpuVendor.Value == GpuVendor.IntelUnix; public static bool SupportsMismatchingViewFormat => _gpuVendor.Value != GpuVendor.Amd && _gpuVendor.Value != GpuVendor.IntelWindows; @@ -88,5 +90,14 @@ namespace Ryujinx.Graphics.OpenGL return GpuVendor.Unknown; } } + + private static bool SupportsQuadsCheck() + { + GL.GetError(); // Clear any existing error. + GL.Begin(PrimitiveType.Quads); + GL.End(); + + return GL.GetError() == ErrorCode.NoError; + } } } \ No newline at end of file -- cgit v1.2.3