From b8e3909d800ff5947683bb169d8efda2ef63d697 Mon Sep 17 00:00:00 2001 From: gdkchan Date: Sun, 12 Jan 2020 20:27:50 -0300 Subject: Add a GetSpan method to the memory manager and use it on GPU (#877) --- Ryujinx.Graphics.Gpu/Memory/MemoryAccessor.cs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'Ryujinx.Graphics.Gpu/Memory/MemoryAccessor.cs') diff --git a/Ryujinx.Graphics.Gpu/Memory/MemoryAccessor.cs b/Ryujinx.Graphics.Gpu/Memory/MemoryAccessor.cs index 18779333..17c00062 100644 --- a/Ryujinx.Graphics.Gpu/Memory/MemoryAccessor.cs +++ b/Ryujinx.Graphics.Gpu/Memory/MemoryAccessor.cs @@ -27,23 +27,23 @@ namespace Ryujinx.Graphics.Gpu.Memory /// Byte array with the data public byte[] ReadBytes(ulong gpuVa, ulong size) { - return Read(gpuVa, size).ToArray(); + return GetSpan(gpuVa, size).ToArray(); } /// - /// Reads data from GPU mapped memory. + /// Gets a read-only span of data from GPU mapped memory. /// This reads as much data as possible, up to the specified maximum size. /// /// GPU virtual address where the data is located /// Maximum size of the data - /// The data at the specified memory location - public Span Read(ulong gpuVa, ulong maxSize) + /// The span of the data at the specified memory location + public ReadOnlySpan GetSpan(ulong gpuVa, ulong maxSize) { ulong processVa = _context.MemoryManager.Translate(gpuVa); ulong size = Math.Min(_context.MemoryManager.GetSubSize(gpuVa), maxSize); - return _context.PhysicalMemory.Read(processVa, size); + return _context.PhysicalMemory.GetSpan(processVa, size); } /// @@ -58,7 +58,7 @@ namespace Ryujinx.Graphics.Gpu.Memory ulong size = (uint)Marshal.SizeOf(); - return MemoryMarshal.Cast(_context.PhysicalMemory.Read(processVa, size))[0]; + return MemoryMarshal.Cast(_context.PhysicalMemory.GetSpan(processVa, size))[0]; } /// @@ -70,7 +70,7 @@ namespace Ryujinx.Graphics.Gpu.Memory { ulong processVa = _context.MemoryManager.Translate(gpuVa); - return BitConverter.ToInt32(_context.PhysicalMemory.Read(processVa, 4)); + return BitConverter.ToInt32(_context.PhysicalMemory.GetSpan(processVa, 4)); } /// @@ -82,7 +82,7 @@ namespace Ryujinx.Graphics.Gpu.Memory { ulong processVa = _context.MemoryManager.Translate(gpuVa); - return BitConverter.ToUInt64(_context.PhysicalMemory.Read(processVa, 8)); + return BitConverter.ToUInt64(_context.PhysicalMemory.GetSpan(processVa, 8)); } /// -- cgit v1.2.3