From f1d1670b0b1b5c08064df95dabd295f3cf5dcf7f Mon Sep 17 00:00:00 2001 From: gdkchan Date: Wed, 16 Nov 2022 14:53:04 -0300 Subject: Implement HLE macro for DrawElementsIndirect (#3748) * Implement HLE macro for DrawElementsIndirect * Shader cache version bump * Use GL_ARB_shader_draw_parameters extension on OpenGL * Fix DrawIndexedIndirectCount on Vulkan when extension is not supported * Implement DrawIndex * Alignment * Fix some validation errors * Rename BaseIds to DrawParameters * Fix incorrect index buffer and vertex buffer size in some cases * Add HLE macros for DrawArraysInstanced and DrawElementsInstanced * Perform a regular draw when indirect data is not modified * Use non-indirect draw methods if indirect buffer was not GPU modified * Only check if draw parameters match if the shader actually uses them * Expose Macro HLE setting on GUI * Reset FirstVertex and FirstInstance after draw * Update shader cache version again since some people already tested this * PR feedback Co-authored-by: riperiperi --- .../MultiDrawIndexedIndirectCountCommand.cs | 29 ---------------------- 1 file changed, 29 deletions(-) delete mode 100644 Ryujinx.Graphics.GAL/Multithreading/Commands/MultiDrawIndexedIndirectCountCommand.cs (limited to 'Ryujinx.Graphics.GAL/Multithreading/Commands/MultiDrawIndexedIndirectCountCommand.cs') diff --git a/Ryujinx.Graphics.GAL/Multithreading/Commands/MultiDrawIndexedIndirectCountCommand.cs b/Ryujinx.Graphics.GAL/Multithreading/Commands/MultiDrawIndexedIndirectCountCommand.cs deleted file mode 100644 index 6798f8cc..00000000 --- a/Ryujinx.Graphics.GAL/Multithreading/Commands/MultiDrawIndexedIndirectCountCommand.cs +++ /dev/null @@ -1,29 +0,0 @@ -namespace Ryujinx.Graphics.GAL.Multithreading.Commands -{ - struct MultiDrawIndexedIndirectCountCommand : IGALCommand - { - public CommandType CommandType => CommandType.MultiDrawIndexedIndirectCount; - private BufferRange _indirectBuffer; - private BufferRange _parameterBuffer; - private int _maxDrawCount; - private int _stride; - - public void Set(BufferRange indirectBuffer, BufferRange parameterBuffer, int maxDrawCount, int stride) - { - _indirectBuffer = indirectBuffer; - _parameterBuffer = parameterBuffer; - _maxDrawCount = maxDrawCount; - _stride = stride; - } - - public static void Run(ref MultiDrawIndexedIndirectCountCommand command, ThreadedRenderer threaded, IRenderer renderer) - { - renderer.Pipeline.MultiDrawIndexedIndirectCount( - threaded.Buffers.MapBufferRange(command._indirectBuffer), - threaded.Buffers.MapBufferRange(command._parameterBuffer), - command._maxDrawCount, - command._stride - ); - } - } -} -- cgit v1.2.3