From f41687f4c1948e9e111afd70e979e98ea5de52fa Mon Sep 17 00:00:00 2001
From: Mary <me@thog.eu>
Date: Mon, 1 Nov 2021 23:38:13 +0100
Subject: hle: Make Ryujinx.HLE project entirely safe (#2789)

* Remove a bit of unsafety around

* Regenerate StructArrayHelpers with a max element value of 256

* hle: remove unsafe marker from all struct that had it

* hle: make SoftwareKeyboardRenderer.TryCopyTo safe

* hle: remove unsafety in NpadDevice and remove AllowUnsafeBlocks from csproj

* Revert "Regenerate StructArrayHelpers with a max element value of 256"

This reverts commit f32a6e5be094f50571970eb1116b65c080781d05.

* Introduce ByteArray of various size and use that instead of ArrayXXX to avoid stackoverflow in .NET runtime type resolution

* Use ByteArray more

* Add some missing spaces on Pack = 1 for various structs

* Fix broken logic for TryCopyTo

* Address gdkchan's comment

* Address gdkchan's comment
---
 Ryujinx.Common/Memory/StructByteArrayHelpers.cs | 77 +++++++++++++++++++++++++
 1 file changed, 77 insertions(+)
 create mode 100644 Ryujinx.Common/Memory/StructByteArrayHelpers.cs

(limited to 'Ryujinx.Common/Memory/StructByteArrayHelpers.cs')

diff --git a/Ryujinx.Common/Memory/StructByteArrayHelpers.cs b/Ryujinx.Common/Memory/StructByteArrayHelpers.cs
new file mode 100644
index 00000000..0c17dc10
--- /dev/null
+++ b/Ryujinx.Common/Memory/StructByteArrayHelpers.cs
@@ -0,0 +1,77 @@
+using System;
+using System.Runtime.InteropServices;
+
+namespace Ryujinx.Common.Memory
+{
+    [StructLayout(LayoutKind.Sequential, Size = Size, Pack = 1)]
+    public struct ByteArray128 : IArray<byte>
+    {
+        private const int Size = 128;
+
+        byte _element;
+
+        public int Length => Size;
+        public ref byte this[int index] => ref ToSpan()[index];
+        public Span<byte> ToSpan() => MemoryMarshal.CreateSpan(ref _element, Size);
+    }
+
+    [StructLayout(LayoutKind.Sequential, Size = Size, Pack = 1)]
+    public struct ByteArray256 : IArray<byte>
+    {
+        private const int Size = 256;
+
+        byte _element;
+
+        public int Length => Size;
+        public ref byte this[int index] => ref ToSpan()[index];
+        public Span<byte> ToSpan() => MemoryMarshal.CreateSpan(ref _element, Size);
+    }
+
+    [StructLayout(LayoutKind.Sequential, Size = Size, Pack = 1)]
+    public struct ByteArray512 : IArray<byte>
+    {
+        private const int Size = 512;
+
+        byte _element;
+
+        public int Length => Size;
+        public ref byte this[int index] => ref ToSpan()[index];
+        public Span<byte> ToSpan() => MemoryMarshal.CreateSpan(ref _element, Size);
+    }
+
+    [StructLayout(LayoutKind.Sequential, Size = Size, Pack = 1)]
+    public struct ByteArray1024 : IArray<byte>
+    {
+        private const int Size = 1024;
+
+        byte _element;
+
+        public int Length => Size;
+        public ref byte this[int index] => ref ToSpan()[index];
+        public Span<byte> ToSpan() => MemoryMarshal.CreateSpan(ref _element, Size);
+    }
+
+    [StructLayout(LayoutKind.Sequential, Size = Size, Pack = 1)]
+    public struct ByteArray2048 : IArray<byte>
+    {
+        private const int Size = 2048;
+
+        byte _element;
+
+        public int Length => Size;
+        public ref byte this[int index] => ref ToSpan()[index];
+        public Span<byte> ToSpan() => MemoryMarshal.CreateSpan(ref _element, Size);
+    }
+
+    [StructLayout(LayoutKind.Sequential, Size = Size, Pack = 1)]
+    public struct ByteArray4096 : IArray<byte>
+    {
+        private const int Size = 4096;
+
+        byte _element;
+
+        public int Length => Size;
+        public ref byte this[int index] => ref ToSpan()[index];
+        public Span<byte> ToSpan() => MemoryMarshal.CreateSpan(ref _element, Size);
+    }
+}
-- 
cgit v1.2.3