From 0c87bf9ea4b0655fc6b90b4ab20e93f237e7549b Mon Sep 17 00:00:00 2001 From: gdkchan Date: Tue, 31 May 2022 16:29:35 -0300 Subject: Refactor CPU interface to allow the implementation of other CPU emulators (#3362) * Refactor CPU interface * Use IExecutionContext interface on SVC handler, change how CPU interrupts invokes the handlers * Make CpuEngine take a ITickSource rather than returning one The previous implementation had the scenario where the CPU engine had to implement the tick source in mind, like for example, when we have a hypervisor and the game can read CNTPCT on the host directly. However given that we need to do conversion due to different frequencies anyway, it's not worth it. It's better to just let the user pass the tick source and redirect any reads to CNTPCT to the user tick source * XML docs for the public interfaces * PPTC invalidation due to NativeInterface function name changes * Fix build of the CPU tests * PR feedback --- Ryujinx.Audio/Renderer/Server/AudioRenderSystem.cs | 4 +--- Ryujinx.Audio/Renderer/Server/AudioRendererManager.cs | 10 +++++++++- 2 files changed, 10 insertions(+), 4 deletions(-) (limited to 'Ryujinx.Audio/Renderer/Server') diff --git a/Ryujinx.Audio/Renderer/Server/AudioRenderSystem.cs b/Ryujinx.Audio/Renderer/Server/AudioRenderSystem.cs index 0c41909e..5fa5b797 100644 --- a/Ryujinx.Audio/Renderer/Server/AudioRenderSystem.cs +++ b/Ryujinx.Audio/Renderer/Server/AudioRenderSystem.cs @@ -523,9 +523,7 @@ namespace Ryujinx.Audio.Renderer.Server private ulong GetSystemTicks() { - double ticks = ARMeilleure.State.ExecutionContext.ElapsedTicks * ARMeilleure.State.ExecutionContext.TickFrequency; - - return (ulong)(ticks * Constants.TargetTimerFrequency); + return (ulong)(_manager.TickSource.ElapsedSeconds * Constants.TargetTimerFrequency); } private uint ComputeVoiceDrop(CommandBuffer commandBuffer, long voicesEstimatedTime, long deltaTimeDsp) diff --git a/Ryujinx.Audio/Renderer/Server/AudioRendererManager.cs b/Ryujinx.Audio/Renderer/Server/AudioRendererManager.cs index d20c3c03..90be7111 100644 --- a/Ryujinx.Audio/Renderer/Server/AudioRendererManager.cs +++ b/Ryujinx.Audio/Renderer/Server/AudioRendererManager.cs @@ -19,6 +19,7 @@ using Ryujinx.Audio.Integration; using Ryujinx.Audio.Renderer.Dsp; using Ryujinx.Audio.Renderer.Parameter; using Ryujinx.Common.Logging; +using Ryujinx.Cpu; using Ryujinx.Memory; using System; using System.Diagnostics; @@ -77,6 +78,11 @@ namespace Ryujinx.Audio.Renderer.Server /// private IHardwareDeviceDriver _deviceDriver; + /// + /// Tick source used to measure elapsed time. + /// + public ITickSource TickSource { get; } + /// /// The instance associated to this manager. /// @@ -90,9 +96,11 @@ namespace Ryujinx.Audio.Renderer.Server /// /// Create a new . /// - public AudioRendererManager() + /// Tick source used to measure elapsed time. + public AudioRendererManager(ITickSource tickSource) { Processor = new AudioProcessor(); + TickSource = tickSource; _sessionIds = new int[Constants.AudioRendererSessionCountMax]; _sessions = new AudioRenderSystem[Constants.AudioRendererSessionCountMax]; _activeSessionCount = 0; -- cgit v1.2.3