From a9343c9364246d3288b4e7f20919ca1ad2e1fd3e Mon Sep 17 00:00:00 2001
From: FICTURE7 <FICTURE7@gmail.com>
Date: Tue, 14 Sep 2021 03:23:37 +0400
Subject: Refactor `PtcInfo` (#2625)

* Refactor `PtcInfo`

This change reduces the coupling of `PtcInfo` by moving relocation
tracking to the backend. `RelocEntry`s remains as `RelocEntry`s through
out the pipeline until it actually needs to be written to the PTC
streams. Keeping this representation makes inspecting and manipulating
relocations after compilations less painful. This is something I needed
to do to patch relocations to 0 to diff dumps.

Contributes to #1125.

* Turn `Symbol` & `RelocInfo` into readonly structs

* Add documentation to `CompiledFunction`

* Remove `Compiler.Compile<T>`

Remove `Compiler.Compile<T>` and replace it by `Map<T>` of the
`CompiledFunction` returned.
---
 ARMeilleure/Translation/PTC/PtcInfo.cs | 63 ----------------------------------
 1 file changed, 63 deletions(-)
 delete mode 100644 ARMeilleure/Translation/PTC/PtcInfo.cs

(limited to 'ARMeilleure/Translation/PTC/PtcInfo.cs')

diff --git a/ARMeilleure/Translation/PTC/PtcInfo.cs b/ARMeilleure/Translation/PTC/PtcInfo.cs
deleted file mode 100644
index b28b2dc1..00000000
--- a/ARMeilleure/Translation/PTC/PtcInfo.cs
+++ /dev/null
@@ -1,63 +0,0 @@
-using ARMeilleure.CodeGen.Unwinding;
-using System;
-using System.IO;
-
-namespace ARMeilleure.Translation.PTC
-{
-    class PtcInfo : IDisposable
-    {
-        private readonly BinaryWriter _relocWriter;
-        private readonly BinaryWriter _unwindInfoWriter;
-
-        public byte[] Code { get; set; }
-
-        public MemoryStream RelocStream      { get; }
-        public MemoryStream UnwindInfoStream { get; }
-
-        public int RelocEntriesCount { get; private set; }
-
-        public PtcInfo()
-        {
-            RelocStream      = new MemoryStream();
-            UnwindInfoStream = new MemoryStream();
-
-            _relocWriter      = new BinaryWriter(RelocStream,      EncodingCache.UTF8NoBOM, true);
-            _unwindInfoWriter = new BinaryWriter(UnwindInfoStream, EncodingCache.UTF8NoBOM, true);
-
-            RelocEntriesCount = 0;
-        }
-
-        public void WriteRelocEntry(RelocEntry relocEntry)
-        {
-            _relocWriter.Write((int)relocEntry.Position);
-            _relocWriter.Write((byte)relocEntry.Symbol.Type);
-            _relocWriter.Write((ulong)relocEntry.Symbol.Value);
-
-            RelocEntriesCount++;
-        }
-
-        public void WriteUnwindInfo(UnwindInfo unwindInfo)
-        {
-            _unwindInfoWriter.Write((int)unwindInfo.PushEntries.Length);
-
-            foreach (UnwindPushEntry unwindPushEntry in unwindInfo.PushEntries)
-            {
-                _unwindInfoWriter.Write((int)unwindPushEntry.PseudoOp);
-                _unwindInfoWriter.Write((int)unwindPushEntry.PrologOffset);
-                _unwindInfoWriter.Write((int)unwindPushEntry.RegIndex);
-                _unwindInfoWriter.Write((int)unwindPushEntry.StackOffsetOrAllocSize);
-            }
-
-            _unwindInfoWriter.Write((int)unwindInfo.PrologSize);
-        }
-
-        public void Dispose()
-        {
-            _relocWriter.Dispose();
-            _unwindInfoWriter.Dispose();
-
-            RelocStream.Dispose();
-            UnwindInfoStream.Dispose();
-        }
-    }
-}
\ No newline at end of file
-- 
cgit v1.2.3